Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include files not installed with CMake #136

Open
Michael-M-Baron opened this issue Nov 4, 2024 · 2 comments · May be fixed by #137
Open

include files not installed with CMake #136

Michael-M-Baron opened this issue Nov 4, 2024 · 2 comments · May be fixed by #137
Assignees
@Michael-M-Baron
Labels
bug Something isn't working in progress this issue is actively being worked on

Comments

@Michael-M-Baron
Copy link
Collaborator

The CMake variable HEADERS is first set at CMakeLists.txt#16 to the list of libjapi header files.

However, in CMakeLists.txt#41 PUBLIC_HEADERS is used to set the PUBLIC_HEADER property of JAPI library object. So in fact an empty list of libraries will be installed.
@Michael-M-Baron Michael-M-Baron added bug Something isn't working in progress this issue is actively being worked on labels Nov 4, 2024
@Michael-M-Baron Michael-M-Baron self-assigned this Nov 4, 2024
@Michael-M-Baron
Copy link
Collaborator Author

Currently only the shared library .so file of libjapi is installed

root@0ac597d0a337:/mnt/build# make install
Scanning dependencies of target japi_objs
[ 12%] Building C object CMakeFiles/japi_objs.dir/src/creadline.c.o
[ 25%] Building C object CMakeFiles/japi_objs.dir/src/japi.c.o
[ 37%] Building C object CMakeFiles/japi_objs.dir/src/japi_pushsrv.c.o
[ 50%] Building C object CMakeFiles/japi_objs.dir/src/japi_utils.c.o
[ 62%] Building C object CMakeFiles/japi_objs.dir/src/networking.c.o
[ 75%] Building C object CMakeFiles/japi_objs.dir/src/rw_n.c.o
[ 75%] Built target japi_objs
Scanning dependencies of target japi
[ 87%] Linking C shared library libjapi.so
[ 87%] Built target japi
Scanning dependencies of target japi-static
[100%] Linking C static library libjapi-static.a
[100%] Built target japi-static
Install the project...
-- Install configuration: "Release"
-- Installing: /usr/local/lib/libjapi.so.1
-- Up-to-date: /usr/local/lib/libjapi.so

@Michael-M-Baron
Copy link
Collaborator Author

After fixing the typo in #136, the install output is now looking

root@b078ae4afe53:/mnt/build# make install
Scanning dependencies of target japi_objs
[ 12%] Building C object CMakeFiles/japi_objs.dir/src/creadline.c.o
[ 25%] Building C object CMakeFiles/japi_objs.dir/src/japi.c.o
[ 37%] Building C object CMakeFiles/japi_objs.dir/src/japi_pushsrv.c.o
[ 50%] Building C object CMakeFiles/japi_objs.dir/src/japi_utils.c.o
[ 62%] Building C object CMakeFiles/japi_objs.dir/src/networking.c.o
[ 75%] Building C object CMakeFiles/japi_objs.dir/src/rw_n.c.o
[ 75%] Built target japi_objs
Scanning dependencies of target japi
[ 87%] Linking C shared library libjapi.so
[ 87%] Built target japi
Scanning dependencies of target japi-static
[100%] Linking C static library libjapi-static.a
[100%] Built target japi-static
Install the project...
-- Install configuration: "Release"
-- Installing: /usr/local/lib/libjapi.so.1
-- Installing: /usr/local/lib/libjapi.so
-- Installing: /usr/local/include/creadline.h
-- Installing: /usr/local/include/japi.h
-- Installing: /usr/local/include/japi_pushsrv.h
-- Installing: /usr/local/include/japi_utils.h
-- Installing: /usr/local/include/networking.h
-- Installing: /usr/local/include/rw_n.h

Cmake is now installing the header files at the default path /usr/local/include. The exact install directory has to be discussed, since it is not globally available at this location what you would expect when installing a library.

@Michael-M-Baron Michael-M-Baron linked a pull request Nov 4, 2024 that will close this issue
Use HEADERS variable to set public header property of libjapi. PUBLIC… #137
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Michael-M-Baron Michael-M-Baron

Labels
bug Something isn't working in progress this issue is actively being worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use HEADERS variable to set public header property of libjapi. PUBLIC… Fraunhofer-IIS/libjapi
1 participant
@Michael-M-Baron