-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean builds on MacOS crash on save #177
Comments
I had similar trouble. If I used llvm@11 all works fine.
|
experienced the save on crash as well. taking a quick look at your output it looks it might be icu4c related. i rebuilt all dependencies on macos mojave and also rebuilt freecad, and have not had an issue. you can check out the dependencies and dmg i put together here |
Hello ipatch. FreeCAD breaks with libc++.1.dylib, which is a part of llvm. Your DMG is too small to included all libs. I think MakeMacBundleRelocatable process stops. Please test my Commit |
hmmm, presently, i'm running macos mojave on my 2013 late macbook pro. i tested the dmg i created yesterday on my box. and everything appears to be working (to the best of my knowledge). something to note, i use the formulae file in this repo to build and install the dependencies, but i've cloned the main freecad repo https://github.com/freecad/freecad and build / install from the main git repo. ie. i don't build & install freecad from the formulae file provided by this repo. i choose to build and install freecad this way, so i can check out & and setup different branches and commits of the freecad source. as the homebrew install process isolates everything a tmp directory that makes managing multiple forks, branches, and commits difficult to work worth. all that said, i have a macos mojave with a minimal homebrew install (setup primarily to be a self hosted runner for github actions) in hopes of autogenerating / building bottles for the tap. so i downloaded the dmg i created yesterday on my mojave vm in qemu/kvm on another macbook 2013 late running arch. and everything appeared to work. i was able to open, create a document, create a body, create a sketch within the body, pad the sketch, and then save the document all in the vm. i have not tested the dmg i created on macos catalina or bigsur. i do have a big sur vm that i created with virtualbox a while, and i'm in the process of getting it to work with qemu on my arch linux install. so when i get all that going i'll test the dmg and report back. more than likely i'll just update the notes in my release of this forked repo. also i haven't setup a catalina vm yet, so i need to get that going after i get my bigsur vm all settled in. stay tuned™️. |
MakeMacBundleRelocatable.py writes at the end 'Done.'. Maybe it helps, to check the process. But this is other topic. We should discuss here. I hope to see you all again soon. |
i just tested my app bundle / dmg from [my most recent release] on a macos big sur vm, and i was able to perform all the basic actions i mentioned above, so i don't completely understand why you say my dmg is too small? below is a screengrab i took running freecad within the big sur vm. |
Hello ipatch, I thought that your DMG is ready to use. But it is compressed. Your DMG is unpack 1,45 GB. Sorry about the confusion. Your DMG runs with rosetta 2. All is fine. |
so this an issue related to llvm. i'll pull in the latest upstream changes from freecad source see i can build with llvm 12 and save a file, and if it works i'll close this issue. otherwise i will leave it open. |
i have llvm latest v12 installed and linked via brew. i set the below env vars to compile freecad from source.
and am unable to reproduce the crash on save at this time.
if anyone knows how to reproduce could you please share, or else i'm going to close this issue. |
@ipatch Please test: Crashed your freecad at end of testing? |
wow, that's neat. did not know about the i'll take a look this. thanks for the heads up. this is what i'm seeing running the tests on my local mojave box. https://gist.github.com/ipatch/f26086fef67badf1db62c293bbf9579a |
Apple Silicon, anyone? |
me 🙋♂️, personally do not have access to an M1 mac, so i could not build bottles for m1 unfortunately. and github actions does not have an m1 environment yet. so you'll more than likely have to build all the deps from source, then you'll be able to build freecad. cheers |
By the way, llvm is now at 13 and with this version I do not get trouble by the saving process. |
But llvm deeps on [email protected]. So we need own formula. Never ending story. |
FWIW i've been working on updating the
and generate a "working" |
adding this for those who follow the upstream bug tracker. |
I am excited about. |
I think the current application bundle created by homebrew is totally broken. The size of the binary is about 780MB while it shall be in the 1.2GB range. It is missing a ton of dependencies. As mentioned by @ageeye. These dependencies were expected to be integrated into src/MacAppBundle/CMakeLists.txt and src/Tools/MakeMacBundleRelocatable.py into a PR but it never went through.I have the patches, and all the issues mentioned within many issues will disappear. I will try to get it upstreamed. I liked the approach of bundling everything into the App instead of maintaining our formula, but we still have some work regarding remaining dependencies. |
@vejmarie ping |
the latest bottled version of freecad v0.20.1 when i installed it on macos catalina. i had a crash on save. to reproduce, open freecad save document. (there should be no crash). create a sketch in the document. (no pading or any other actions required). then save the document again. the app should crash once a sketch is added to the body. more than likely this is related to llvm again. |
stack trace / crash report from current bottle install on catalina, crash on save with a document containing a sketch.
|
I have been building FreeCAD for a few weeks, and each build on MacOS crashes on save. Weekly builds downloaded (using Conda) do not crash. I have tried building with --with-debug, but it doesn't seem to work - I get no source in the stack trace under lldb. Latest build from yesterday: HEAD-cb2edd1
The text was updated successfully, but these errors were encountered: