Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Konflikt mit yform_geo_osm #30

Closed
christophboecker opened this issue Feb 23, 2022 · 3 comments · Fixed by #32
Closed

Konflikt mit yform_geo_osm #30

christophboecker opened this issue Feb 23, 2022 · 3 comments · Fixed by #32
Labels
conflict Conflict with another addon, tool, etc. documentation Improvements or additions to documentation

Comments

@christophboecker
Copy link
Member

Beide bringen Leaflet mit, das kracht aus JS-Ebene. Würde sich mit #28 und einer neuen Version von yform_geo_osm lösen. Könnte man b.a.w. in der package.yml lösen:

conflicts:
    packages:
        yform_geo_osm: '>0.0.0'

Und Hinweise in der README.md, docs/install.md sowie im Installer.
@christophboecker christophboecker added documentation Improvements or additions to documentation conflict Conflict with another addon, tool, etc. labels Feb 23, 2022
@christophboecker christophboecker mentioned this issue Feb 23, 2022
Merged
@christophboecker
Copy link
Member Author

Installer geändert.

@skerbis
Copy link
Member

skerbis commented Feb 23, 2022

würde es anders machen und in GeoOSM prüfen ob Geolocatian aktiv ist. So dass das aktuelle Leaflet von Geolocation verwendet wird.

@christophboecker
Copy link
Member Author

Das ist jetzt erstmal „Absicherung“. Und müsste m.E. mit angepasster Version (<x.y.z) drinbleiben, nachdem es eine neue yform_geo_osm mit geolocation-Detektor gibt. Oder mit Abhängigkeit zu geolocation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
conflict Conflict with another addon, tool, etc. documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Konflikt mit yform_geo_osm berücksichtigt FriendsOfREDAXO/geolocation
2 participants
@skerbis @christophboecker