Skip to content

Commit

Permalink
Adding internal comments
Browse files Browse the repository at this point in the history
  • Loading branch information
mamazu committed Jan 6, 2025
1 parent aef1878 commit 167cfd3
Show file tree
Hide file tree
Showing 16 changed files with 22 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

namespace FriendsOfSulu\MakerBundle\Maker\AdminConfigurationMaker;

/** @internal */
class AdminGeneratorSettings
{
public bool $shouldAddMenuItem = true;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Question\ChoiceQuestion;

class MakeAdminConfigurationCommand extends AbstractMaker
/** @internal */
final class MakeAdminConfigurationCommand extends AbstractMaker
{
use ConsoleHelperTrait;

Expand Down
1 change: 1 addition & 0 deletions src/Maker/ControllerMaker/ControllerGeneratorSettings.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

namespace FriendsOfSulu\MakerBundle\Maker\ControllerMaker;

/** @internal */
class ControllerGeneratorSettings
{
public bool $shouldHaveGetListAction = true;
Expand Down
3 changes: 2 additions & 1 deletion src/Maker/ControllerMaker/MakeControllerCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
use Symfony\Component\Console\Input\InputOption;
use Webmozart\Assert\Assert;

class MakeControllerCommand extends AbstractMaker
/** @internal */
final class MakeControllerCommand extends AbstractMaker
{
use ConsoleHelperTrait;

Expand Down
1 change: 1 addition & 0 deletions src/Maker/ListConfigurationMaker/ConditionType.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

namespace FriendsOfSulu\MakerBundle\Maker\ListConfigurationMaker;

/** @internal */
enum ConditionType: string
{
case ON = 'ON';
Expand Down
1 change: 1 addition & 0 deletions src/Maker/ListConfigurationMaker/JoinType.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

namespace FriendsOfSulu\MakerBundle\Maker\ListConfigurationMaker;

/** @internal */
enum JoinType: string
{
case LEFT = 'LEFT';
Expand Down
1 change: 1 addition & 0 deletions src/Maker/ListConfigurationMaker/ListJoinInfo.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

namespace FriendsOfSulu\MakerBundle\Maker\ListConfigurationMaker;

/** @internal */
class ListJoinInfo
{
public function __construct(
Expand Down
1 change: 1 addition & 0 deletions src/Maker/ListConfigurationMaker/ListPropertyInfo.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

use FriendsOfSulu\MakerBundle\Enums\Visibility;

/** @internal */
class ListPropertyInfo
{
public function __construct(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
use Symfony\Bundle\MakerBundle\ConsoleStyle;
use Webmozart\Assert\Assert;

/** @internal */
class ListPropertyInfoProvider
{
use ConsoleHelperTrait;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@
use Symfony\Component\Filesystem\Exception\FileNotFoundException;
use Webmozart\Assert\Assert;

class MakeListConfigurationCommand extends AbstractMaker
/** @internal */
final class MakeListConfigurationCommand extends AbstractMaker
{
use ConsoleHelperTrait;

Expand Down
3 changes: 2 additions & 1 deletion src/Maker/PreviewMaker/MakePreviewCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@
use Symfony\Component\Console\Input\InputOption;
use Webmozart\Assert\Assert;

class MakePreviewCommand extends AbstractMaker
/** @internal */
final class MakePreviewCommand extends AbstractMaker
{
use ConsoleHelperTrait;

Expand Down
3 changes: 2 additions & 1 deletion src/Maker/SuluPageMaker/MakePageTypeCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;

class MakePageTypeCommand extends AbstractMaker
/** @internal */
final class MakePageTypeCommand extends AbstractMaker
{
private const ARG_PAGE_KEY = 'pageKey';
private const OPT_CONTROLLER = 'controller';
Expand Down
3 changes: 2 additions & 1 deletion src/Maker/TashHandlerMaker/MakeTrashHandlerCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;

class MakeTrashHandlerCommand extends AbstractMaker
/** @internal */
final class MakeTrashHandlerCommand extends AbstractMaker
{
use ConsoleHelperTrait;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

namespace FriendsOfSulu\MakerBundle\Maker\TashHandlerMaker;

/** @internal */
class TashHandlerGeneratorSettings
{
public function __construct(
Expand Down
2 changes: 1 addition & 1 deletion src/Property/PropertyToSuluTypeGuesser.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

namespace FriendsOfSulu\MakerBundle\Property;

class PropertyToSuluTypeGuesser implements PropertyToSuluTypeGuesserInterface
final class PropertyToSuluTypeGuesser implements PropertyToSuluTypeGuesserInterface
{
public function getPossibleTypes(string $doctrineType): array
{
Expand Down
2 changes: 1 addition & 1 deletion src/Utils/NameGenerators/ResourceKeyExtractor.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

use Webmozart\Assert\Assert;

class ResourceKeyExtractor implements UniqueNameGenerator
final class ResourceKeyExtractor implements UniqueNameGenerator
{
private const RESOURCE_KEY_CONSTANT = 'RESOURCE_KEY';

Expand Down

0 comments on commit 167cfd3

Please sign in to comment.