Issue#2698 persist column visibility state stage 3 completes issue #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GALTdea
force-pushed
the
issue#2698_persist_column_visibility_state_stage_2_add_table_state_to_preference_sets_rake_task
branch
from
6135872
to
6c459b6
Compare
GALTdea
force-pushed
the
issue#2698_persist_column_visibility_state_stage_3_completes_issue
branch
from
7d07fb2
to
bd76d7b
Compare
haiderRizvii
suggested changes
May 3, 2023
| @preference_set ||= PreferenceSet.find_by!(user_id: user_id) | ||
| end | ||
|
|
||
| end |
| end | ||
| end | ||
| end | ||
| end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
(3/3) #2
What changed, and why?
It adds preference_sets controller with two new actions that will load and update the table_state from preference_sets table. I also adds a service object that will hundle table_state.
How will this affect user permissions?
How is this tested? (please write tests!) 💖💪
A service test has been added to test this new class. In it I cover 4 cases:
table_state
--when proference_set exist: return the data
--when there's not data: return nil
update
--when the update is successful: updates the table state
--when the update fails: it should raise and error
Screenshots please :)
Feelings gif (optional)
What gif best describes your feeling working on this issue? https://giphy.com/
How to embed:
Feedback please? (optional)
We are very interested in your feedback! Please give us some :) https://forms.gle/1D5ACNgTs2u9gSdh9