Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change table sorting behavior default #1253

Open
billingb opened this issue Nov 5, 2024 · 2 comments
Open

Change table sorting behavior default #1253

billingb opened this issue Nov 5, 2024 · 2 comments
Assignees
Labels
Documentation Related to Nunaliit documentation or wiki Enhancement Desired improvement to design or implementation that adds value. JavaScript Nunaliit JavaScript related
Milestone

Comments

@billingb
Copy link
Collaborator

billingb commented Nov 5, 2024

Introduce new sorting for tables that is:
1st column click -> assign primary sort
1st column clicks on columns not yet clicked -> assign secondary, tertiary, etc

2nd column click on already sorted column -> reverse sorting from ascending to descending on that column
3rd column click on already sorted column -> remove the sorting on that column

This new behavior should be added as the default behavior with a configuration option for the current sorting behavior.

@billingb billingb self-assigned this Nov 5, 2024
@billingb
Copy link
Collaborator Author

billingb commented Nov 5, 2024

Vuetify example that shows this behavior: https://vuetifyjs.com/en/components/data-tables/data-and-display/#multi-sort

@ahayes
Copy link
Member

ahayes commented Nov 5, 2024

Interesting. I find that vuetifyjs example to be more complicated than I have seen anywhere else, and because it isn't familiar it took some time to play and figure out how it worked. But because it is self-consistent and has sufficient visual cues to help figure it out, I think it could be OK as our default for tables. Normally I'd expect an opt-in for changes to existing behaviour but in this case, because it isn't breaking and includes the UI and style changes to help immediately see and work with the change in behaviour, I'm OK with changing the default and providing an option to revert behaviour.

@ahayes ahayes added Enhancement Desired improvement to design or implementation that adds value. JavaScript Nunaliit JavaScript related Documentation Related to Nunaliit documentation or wiki labels Nov 5, 2024
@ahayes ahayes added this to the 2.2.9 milestone Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Related to Nunaliit documentation or wiki Enhancement Desired improvement to design or implementation that adds value. JavaScript Nunaliit JavaScript related
Projects
None yet
Development

No branches or pull requests

2 participants