Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use utility to have finer control over map cluster click behaviour #628

Open
jpfiset opened this issue Feb 22, 2017 · 1 comment
Open

Use utility to have finer control over map cluster click behaviour #628

jpfiset opened this issue Feb 22, 2017 · 1 comment
Labels
Enhancement Desired improvement to design or implementation that adds value.
Milestone

Comments

@jpfiset
Copy link
Collaborator

jpfiset commented Feb 22, 2017

Map cluster click is controlled by a custom setting. This means that it is generally atlas wide.

Moving this function to a utility allows the behaviour to be defined on the basis of a module.

The custom behaviour that is seeked is to be able to control if zoom is used dependent on size of cluster and map zoom.

@jpfiset jpfiset added the Enhancement Desired improvement to design or implementation that adds value. label Feb 22, 2017
@jpfiset jpfiset added this to the 2.2.9 milestone Feb 22, 2017
@jpfiset jpfiset self-assigned this Feb 22, 2017
jpfiset added a commit that referenced this issue Feb 22, 2017
mapClusterClickToZoom, mapClusterClickToMultiSelect and
mapClusterClickHandler.

Issue #628
@jpfiset jpfiset closed this as completed Feb 28, 2017
@ahayes ahayes reopened this Mar 4, 2017
@ahayes
Copy link
Member

ahayes commented Mar 4, 2017

This seems to have introduced significant lag when clicking to zoom, to the point where I sometimes feel the need to click again and sometimes it then happens right away, other times it seems to hesitate again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Desired improvement to design or implementation that adds value.
Projects
None yet
Development

No branches or pull requests

2 participants