Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified geometry rendering should occur regardless of decision to employ clustering #637

Open
ahayes opened this issue Mar 13, 2017 · 2 comments
Labels
Enhancement Desired improvement to design or implementation that adds value.
Milestone

Comments

@ahayes
Copy link
Member

ahayes commented Mar 13, 2017

Using a model-driven map with very small polygonal features and clustering off, the features are initially drawn as the simplified points but are then replaced with their polygon renderings despite being very small (as much as a few pixels) at the current scale.

@ahayes ahayes added the Bug Design or implementation flaw that causes grief. label Mar 13, 2017
@ahayes ahayes added this to the 2.2.9 milestone Mar 13, 2017
@jpfiset jpfiset added Enhancement Desired improvement to design or implementation that adds value. and removed Bug Design or implementation flaw that causes grief. labels Mar 21, 2017
@jpfiset
Copy link
Collaborator

jpfiset commented Mar 21, 2017

When clustering is not enabled, then there is no opportunity to transform a polygon or a line to a point.

As far as the geometry simplification performed on the server side, little improvement can be done. This is because the server can not predict the projection that the geometry will be displayed in.

The logic of transforming lines and polygons to points has to be performed on the client side. More particularly, it should be done in the NunaliitFeatureStrategy. Currently, the desired logic exists in the clustering process. The logic should be repeated for non-clustering overlays.

jpfiset added a commit that referenced this issue Mar 21, 2017
Smaller geometries are turned into points.

Issue #637
jpfiset added a commit that referenced this issue Mar 21, 2017
@jpfiset jpfiset closed this as completed Mar 21, 2017
@jpfiset
Copy link
Collaborator

jpfiset commented Mar 21, 2017

Thinking this over, we should probably remove the dynamic clustering of lines and polygons from the clustering process. It is now a duplication of the minimumSize process and would lead to confusion.

Also, minimumSize process should always be installed.

@jpfiset jpfiset reopened this Mar 21, 2017
@ahayes ahayes changed the title Simplified geometry rendering failing in some cases Simplified geometry rendering not happening unless clustering turned on Mar 24, 2017
@ahayes ahayes changed the title Simplified geometry rendering not happening unless clustering turned on Simplified geometry rendering not occurring with clustering off Mar 24, 2017
@ahayes ahayes changed the title Simplified geometry rendering not occurring with clustering off Simplified geometry rendering should occur regardless of decision to employ clustering Mar 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Desired improvement to design or implementation that adds value.
Projects
None yet
Development

No branches or pull requests

2 participants