Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Community Guidelines #34

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Added Community Guidelines #34

merged 2 commits into from
Oct 27, 2023

Conversation

dalvishruti14
Copy link
Contributor

Popup window to display community guidelines is added. #28

@netlify
Copy link

netlify bot commented Oct 15, 2023 •
edited
Loading

✅ Deploy Preview for gdsc-fcrit ready!

Name Link
🔨 Latest commit 5d2ac25
🔍 Latest deploy log https://app.netlify.com/sites/gdsc-fcrit/deploys/65367ff8a7302000087cfd68
😎 Deploy Preview https://deploy-preview-34--gdsc-fcrit.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@karishmarajput
Copy link
Collaborator

Hey Shruti, please do the following changes

  • Make the pop up (Modal) fix position in the center of page.
  • Close button to be at the right corner of modal.
  • Try to add small animation like when hover on close button colour changes.
  • For mobile view please add some margin for modal.

@Savio629
Copy link
Contributor

@dalvishruti14 do update the pr.

@Savio629 Savio629 added the hacktoberfest happy Contributing label Oct 27, 2023
Savio629
Savio629 approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@Savio629 Savio629 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Savio629 Savio629 merged commit 43b37b5 into GDSC-FCRIT:main Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Savio629 Savio629 Savio629 approved these changes

Assignees
No one assigned
Labels
hacktoberfest happy Contributing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dalvishruti14 @karishmarajput @Savio629