Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speaks For ugly log message in am_method_context #870

Open
ahelsing opened this issue Nov 19, 2015 · 0 comments
Open

Speaks For ugly log message in am_method_context #870

ahelsing opened this issue Nov 19, 2015 · 0 comments
Labels

Comments

@ahelsing
Copy link
Member

am_method_context replaces the caller cert before calling the authorizer. The result is that the authorizer does not see the original caller cert, but does see the speaks for option. And so it prints a warning. The call goes on to be authorized, so nothing is broken. But it looks ugly.

EG:

INFO:gcf.am2:Speaks-for invocation: urn:publicid:IDN+ch-ah.gpolab.bbn.com+user+ahelsing for urn:publicid:IDN+ch-ah.gpolab.bbn.com+user+phelin01
INFO:cred-verifier:Got speaks-for option but not a valid speaks_for with this credential: ABAC statement doesn't assert U.speaks_for(U)<-T ([ABAC cred: urn:publicid:IDN+ch-ah.gpolab.bbn.com+user+phelin01 (7e5c5b66579e7a1e33793c64ac29dd656e9ee4d1).speaks_for_7e5c5b66579e7a1e33793c64ac29dd656e9ee4d1<-urn:publicid:IDN+ch-ah.gpolab.bbn.com+user+ahelsing (a2e4d4dc3c39993c652c8446be9e5a9c43daefd1)])
INFO:gcf.am2:CreateSliver('urn:publicid:IDN+ch-ah.gpolab.bbn.com:ahtest+slice+ahtest')
INFO:cred-verifier:Speaks-for Invocation: urn:publicid:IDN+ch-ah.gpolab.bbn.com+user+ahelsing speaking for urn:publicid:IDN+ch-ah.gpolab.bbn.com+user+phelin01

We could avoid this ugliness in a couple ways:

  • pass in the original caller cert to the authorizer.authorize call in am_method_context
  • maybe do the authorize before handling speaks for? Not sure that would work with all authorizers
  • remove the geni_speaking_for option from the options passed to authorizer.authorize
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant