Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set CMP0135 to new #281

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Set CMP0135 to new #281

wants to merge 4 commits into from

Conversation

victorapm
Copy link
Contributor

Closes #277

rrsettgast
rrsettgast reviewed Aug 28, 2024
View reviewed changes
Copy link
Member

@rrsettgast rrsettgast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a few CMP changes in the main repo as well??

CMakeLists.txt
@@ -1,4 +1,9 @@
cmake_minimum_required(VERSION 3.23.1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cmake_minimum_required(VERSION 3.23.1)
cmake_minimum_required(VERSION 3.26.3)

@CusiniM @wrtobin I think this is a good version to set...any objection?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, the newest cmake available on Frontier via module load is 3.23.2

@rrsettgast rrsettgast requested a review from white238 August 28, 2024 16:30
@victorapm
Copy link
Contributor Author

@rrsettgast @CusiniM should we go with 3.24 also for the TPL repo?

https://github.com/GEOS-DEV/GEOS/blob/41e95e34dfef61b4cf1629e5c9ac425fccad0643/src/CMakeLists.txt#L2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrsettgast rrsettgast rrsettgast left review comments

@CusiniM CusiniM Awaiting requested review from CusiniM

@white238 white238 Awaiting requested review from white238

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CMake warnings from ExternalProject_Add
2 participants
@victorapm @rrsettgast