Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FMS 2025 does not support our fvdycore #108

Open
mathomp4 opened this issue Feb 7, 2025 · 3 comments
Open

FMS 2025 does not support our fvdycore #108

mathomp4 opened this issue Feb 7, 2025 · 3 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@mathomp4
Copy link
Member

mathomp4 commented Feb 7, 2025

As noted in the release notes of FMS 2025.01:

  • MPP_IO/FMS_IO: A deprecation warning will now be output when using these modules or enabling the -Duse_deprecated_io flag via the build systems. Usage of these modules will be deprecated in the next release. (Fms io deprecation warning NOAA-GFDL/FMS#1609)

And as our fvdycore is out of sync (in some ways) with the mother repo, we still use the old deprecated IO layers. Thus, FMS 2025.01 might be the last time we can update the fvdycore in GEOS until we update to the latest IO.

From what I can see of the mother repo, this PR by @laurenchilutti:

NOAA-GFDL#74

is at least a starting point to see what the changes needed are.

But, the changes are in bits of fvdycore I'm a bit hesitant to go near. Thus, I've added @wmputman as an assignee. Perhaps he can figure out how to integrate these changes into our fvdycore so that we can continue to use FMS 2025+

@mathomp4 mathomp4 added the help wanted Extra attention is needed label Feb 7, 2025
@mathomp4
Copy link
Member Author

mathomp4 commented Feb 7, 2025

Even worse, our FV3 cannot even use 2025+ as our code is so old we are still referring to mosaic1 and that is now removed in favor of mosaic2

@laurenchilutti
Copy link

@mathomp4 I have a few PRs that have addressed outdated FMS functions in the dycore that I hope wouldn't be too difficult to cherry-pick into this GEOS-ESM fork:

The biggest changes were in May 2021 PR 74, which you mention in this Bug's description.

And the mosaic1->2 changes are in PR 257 and not too complex.

@mathomp4 mathomp4 changed the title FMS might soon not support our fvdycore FMS 2025 does not support our fvdycore Feb 7, 2025
@mathomp4
Copy link
Member Author

mathomp4 commented Feb 7, 2025

@laurenchilutti Thanks. Though "not too complex" given the age of our fvdycore... eeeeeeeee...

Hopefully we can get there "soon".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants