-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Silence error messages in getChannel() and getWavelength(), and add header file in process library #249
Conversation
@amdasilva This PR exposes one of the downsides of having the process library not depending on MAPL. We lose some useful error handling utilities this way. At what point to we accept that CCPP is no longer something that needs support? |
I really hope that we are not thinking of stopping support for this.
On Fri, Aug 4, 2023 at 11:52 AM Tom Clune ***@***.***> wrote:
@amdasilva <https://github.com/amdasilva> This PR exposes one of the
downsides of having the process library not depending on MAPL. We lose some
useful error handling utilities this way. At what point to we accept that
CCPP is no longer something that needs support?
—
Reply to this email directly, view it on GitHub
<#249 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFIUVN4HNOANWUWRT2N3QNLXTULDPANCNFSM6AAAAAA2Y2TPEU>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
Barry Baker
National Oceanic and Atmospheric Administration
Air Resources Laboratory
Physical Research Scientist
Chemical Modeling and Emissions Group Leader
NCWCP, R/ARL, Rm. 4204
5830 University Research Court
College Park, Maryland 20740
Phone: (301) 683-1395
|
@bbakernoaa Are you aware of any activity in that direction? I'm sure we're not changing anything without lots of review to be certain we are not closing any important doors. |
Yes. There is going to be some work towards this in the near future.
Barry Baker
National Oceanic and Atmospheric Administration
Air Resources Laboratory
Physical Research Scientist
Chemical Modeling and Emissions Group Leader
NCWCP, R/ARL, Rm. 4204
5830 University Research Court
College Park, Maryland 20740
Phone: (301) 683-1395
…On Fri, Aug 4, 2023 at 12:52 PM Tom Clune ***@***.***> wrote:
@bbakernoaa <https://github.com/bbakernoaa> Are you aware of any activity
in that direction? I'm sure we're not changing anything without lots of
review to be certain we are not closing any important doors.
—
Reply to this email directly, view it on GitHub
<#249 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFIUVN76FGHJGBYH7YJVSKDXTUSFBANCNFSM6AAAAAA2Y2TPEU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@rmontuoro Unfortunately, it is not just the macros. There are a handful of procedures involved as well. We could create a "MAPL-lite" and make that a dependency. If we get frustrated enough, I suppose we could look into that. I'd also like to use pflogger in that layer, but same issue ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@tclune No, it is a bad idea to have any dependency on MAPL and ESMF. This defeats the purpose of isolating the ESMF code. Also, any simple offline utility that needs any of this functionally will need to depend on a gigantic library. Keep the Process Library self contained and basic. |
I understand. Just illuminating the tradeoff. Dependencies are also bad. I hate shades of grey. |
Resubmitting PR #248 against
develop
to address issue #247.