Skip to content
PHP Coding Standards

wip: improved OrganInformation approval #1193

Sign in to view logs

wip: improved OrganInformation approval

wip: improved OrganInformation approval #1193

Triggered via pull request December 3, 2024 13:06
@tomuddingtomudding
synchronize #1903
tomudding:feature/improved-organ-information-approval
Status Failure
Total duration 50s
Artifacts –

coding-standards.yml

on: pull_request
Matrix: php-codesniffer / PHP_CodeSniffer
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 9 warnings
php-codesniffer / PHP_CodeSniffer (8.3): module/Decision/src/Hydrator/OrganInformation.php#L33
Method \Decision\Hydrator\OrganInformation::hydrate() does not have @param annotation for its traversable parameter $data.
php-codesniffer / PHP_CodeSniffer (8.3): module/Decision/src/Mapper/Organ.php#L54
Multi-line function calls must have a trailing comma after the last parameter.
php-codesniffer / PHP_CodeSniffer (8.3): module/Decision/src/Mapper/Organ.php#L73
Multi-line function calls must have a trailing comma after the last parameter.
php-codesniffer / PHP_CodeSniffer (8.3): module/Decision/src/Controller/Factory/OrganAdminApprovalControllerFactory.php#L17
Method \Decision\Controller\Factory\OrganAdminApprovalControllerFactory::__invoke() does not have native type hint for its parameter $requestedName but it should be possible to add it based on @param annotation "string".
php-codesniffer / PHP_CodeSniffer (8.3): module/Decision/src/Controller/OrganAdminController.php#L7
Type Decision\Model\OrganInformation (as OrganInformationModel) is not used in this file.
php-codesniffer / PHP_CodeSniffer (8.3): module/Decision/src/Model/OrganInformation.php#L121
@var annotation of property \Decision\Model\OrganInformation::$updateProposals does not specify type hint for its items.
php-codesniffer / PHP_CodeSniffer (8.3): module/Decision/src/Model/OrganInformation.php#L198
Method \Decision\Model\OrganInformation::getUpdateProposals() does not have @return annotation for its traversable return value.
php-codesniffer / PHP_CodeSniffer (8.3): module/Decision/src/Controller/OrganAdminApprovalController.php#L7
Type Application\Form\ModifyRequest (as RequestForm) is not used in this file.
php-codesniffer / PHP_CodeSniffer (8.3): module/Decision/src/Controller/OrganAdminApprovalController.php#L8
Type Application\Model\Enums\ApprovableStatus is not used in this file.
php-codesniffer / PHP_CodeSniffer (8.3): module/Decision/src/Controller/OrganAdminApprovalController.php#L12
Type Laminas\Http\Request is not used in this file.
php-codesniffer / PHP_CodeSniffer (8.3)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
php-codesniffer / PHP_CodeSniffer (8.3): module/Application/src/Extensions/CommonMark/VideoIframe/Parsers/VimeoUrlParser.php#L16
Line exceeds 120 characters; contains 197 characters
php-codesniffer / PHP_CodeSniffer (8.3): module/Application/src/Extensions/CommonMark/VideoIframe/Parsers/YouTubeUrlParser.php#L16
Line exceeds 120 characters; contains 133 characters
php-codesniffer / PHP_CodeSniffer (8.3): module/Photo/src/Mapper/Tag.php#L64
Line exceeds 120 characters; contains 131 characters
php-codesniffer / PHP_CodeSniffer (8.3): module/Application/src/Command/LoadFixtures.php#L55
Line exceeds 120 characters; contains 122 characters
php-codesniffer / PHP_CodeSniffer (8.3): module/Photo/src/Form/Album.php#L97
Line exceeds 120 characters; contains 135 characters
php-codesniffer / PHP_CodeSniffer (8.3): module/Application/src/View/HelperTrait.php#L35
Line exceeds 120 characters; contains 129 characters
php-codesniffer / PHP_CodeSniffer (8.3): module/Application/src/View/HelperTrait.php#L37
Line exceeds 120 characters; contains 167 characters
php-codesniffer / PHP_CodeSniffer (8.3): module/Decision/src/Service/Gdpr.php#L50
Line exceeds 120 characters; contains 131 characters