wip: improved OrganInformation approval
#487
tomuddingAnnotations
10 errors and 1 warning
|
PHPStan:
module/Decision/src/Controller/Factory/OrganAdminApprovalControllerFactory.php#L25
The service "decision_mapper_organInformation" was not configured in Psr\Container\ContainerInterface.
|
|
PHPStan:
module/Decision/src/Controller/OrganAdminApprovalController.php#L29
Property Decision\Controller\OrganAdminApprovalController::$organService is never read, only written.
|
|
PHPStan:
module/Decision/src/Controller/OrganAdminApprovalController.php#L50
Method Decision\Controller\OrganAdminApprovalController::approvalAction() should return Laminas\View\Model\ViewModel but return statement is missing.
|
|
PHPStan:
module/Decision/src/Controller/OrganAdminApprovalController.php#L55
Method Decision\Controller\OrganAdminApprovalController::changeApprovalStatusAction() should return Laminas\Http\Response|Laminas\View\Model\ViewModel but return statement is missing.
|
|
PHPStan:
module/Decision/src/Controller/OrganAdminApprovalController.php#L60
Method Decision\Controller\OrganAdminApprovalController::proposalAction() should return Laminas\View\Model\ViewModel but return statement is missing.
|
|
PHPStan:
module/Decision/src/Controller/OrganAdminApprovalController.php#L65
Method Decision\Controller\OrganAdminApprovalController::changeProposalStatusAction() should return Laminas\Http\Response|Laminas\View\Model\ViewModel but return statement is missing.
|
|
PHPStan:
module/Decision/src/Controller/OrganAdminController.php#L105
Strict comparison using === between false and Decision\Model\OrganInformation|null will always evaluate to false.
|
|
PHPStan:
module/Decision/src/Controller/OrganAdminController.php#L115
Parameter #1 $organ of method Decision\Service\Organ::getOrganInformationForm() expects Decision\Model\Organ|null, Decision\Model\OrganInformation|null given.
|
|
PHPStan:
module/Decision/src/Hydrator/OrganInformation.php#L49
Expression on left side of ?? is not nullable.
|
|
PHPStan:
module/Decision/src/Hydrator/OrganInformation.php#L56
Expression on left side of ?? is not nullable.
|
|
PHPStan
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|