Fix issues with data retrieval for GDPR requests

Unnecessary `JOIN` removed and required `?->` added.
GEWIS · Jan 1, 2024 · 9df01ab · 9df01ab
1 parent add7f3a
commit 9df01ab
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/module/Activity/src/Model/SignupFieldValue.php b/module/Activity/src/Model/SignupFieldValue.php
@@ -126,7 +126,7 @@ public function toGdprArray(): array
         return [
             'id' => $this->getId(),
             'value' => $this->getValue(),
-            'option' => $this->getOption()->toGdprArray(),
+            'option' => $this->getOption()?->toGdprArray(),
         ];
     }
 }
diff --git a/module/User/src/Mapper/ApiAppAuthentication.php b/module/User/src/Mapper/ApiAppAuthentication.php
@@ -57,10 +57,9 @@ public function getLastAuthentication(
     public function getMemberAuthenticationsPerApiApp(MemberModel $member): array
     {
         $qb = $this->getRepository()->createQueryBuilder('a');
-        $qb->select('a, app')
-            ->leftJoin(ApiAppModel::class, 'app', 'WITH', 'a.apiApp = app.id')
+        $qb->select('a')
             ->where('a.user = :user_id')
-            ->groupBy('app.appId')
+            ->groupBy('a.apiApp')
             ->orderBy('a.time', 'DESC')
             ->setParameter('user_id', $member->getLidnr());