Add search highlighting to decision search #1764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows you to quickly identify your search prompt in the
contents of the returned decisions. Through transliteration it is
possible to highlight accented text (which is also done by MariaDB)
when searching with plain ASCII text, and vice-versa.
The markers are progressively inserted into the original decision
contents by iterating with `mb_stripos` (note: case-insensitive).
---
Original implementation used `preg_replace`, however, this does not
work with the accented characters:
```php
<?= preg_replace(
sprintf('/(%s)/i', preg_quote($this->escapeHtml($prompt), '/')),
'<mark>$1</mark>',
$this->escapeHtml($decision->getContent()),
) ?>
```
For example, searching for `geinstalleerd` would return results
containing `geïnstalleerd`. However, these would not be highlighted.
github-actions bot
added a commit
that referenced
this pull request
Nov 19, 2023
Tom Udding: Merge pull request #1764 from tomudding/feature/marked-decision-search-results Add search highlighting to decision search Co-authored-by: tomudding <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to quickly identify your search prompt in the contents of the returned decisions. Through transliteration it is possible to highlight accented text (which is also done by MariaDB) when searching with plain ASCII text, and vice-versa.
The markers are progressively inserted into the original decision contents by iterating with
mb_stripos(note: case-insensitive).Original implementation used
preg_replace, however, this does not work with the accented characters:For example, searching for
geinstalleerdwould return results containinggeïnstalleerd. However, these would not be highlighted.Closes GH-1763.