Switch activity subscription from well to modal #1765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make it easier to subscribe to activities, the subscription form is now a modal. This prevents the page from scrolling and allows for some magic auto re-openings of the modal if there is an error. This also changes the states the activity subscription button can be in to ensure that it is easier to see what will happen.
github-actions bot
added a commit
that referenced
this pull request
Nov 19, 2023
Tom Udding: Merge pull request #1765 from tomudding/feature/activity-sign-up-through-modal Switch activity subscription from well to modal Co-authored-by: tomudding <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make it easier to subscribe to activities, the subscription form is now a modal. This prevents the page from scrolling and allows for some magic auto re-openings of the modal if there is an error.
This also changes the states the activity subscription button can be in to ensure that it is easier to see what will happen.
Can subscribe as GEWIS member (logged in)
Can subscribe as GEWIS member (logged out)
Can subscribe as external participant
Subscribed and can unsubscribe
Subscribed and cannot unsubscribe
Not subscribed and cannot (un)subscribe
Closes GH-1752.