feat: improved activity in news article experience #1897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there are fewer news article than `news_count` we now add the `$activities` in random order.
Now you no longer have to search for the activity or clear somewhere else on the same page.
github-actions bot
added a commit
that referenced
this pull request
Sep 2, 2024
Tom Udding: Merge pull request #1897 from tomudding/feature/improved-activity-in-news-article-experience feat: improved activity in news article experience Co-authored-by: tomudding <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Randomly sort the activities that are put in if there are too few
NewsItems. This cannot be done with the old code and a simpleshuffleas theusortautomatically produced the same result.Also makes the header an actual link
Related issues/external references
Closes GH-1894 and closes GH-1895.
Types of changes