fix: conflict in permissions for decisions for active members #1908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Active members were able to see the 'Meetings' tab due to the `decision_admin` being too broad. We could have gone for a `viewOrgan` privilege on the `decision_admin` object, however, it feels better to make it a separate `decision_organ_admin`.
github-actions bot
added a commit
to tomudding/gewisweb
that referenced
this pull request
Oct 18, 2024
Tom Udding: Merge pull request GEWIS#1908 from tomudding/fix/admin-resources-decisions fix: conflict in permissions for decisions for active members Co-authored-by: tomudding <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Active members were able to see the 'Meetings' tab due to the
decision_adminbeing too broad.We could have gone for a
viewOrganprivilege on thedecision_adminobject, however, it feels better to make it a separatedecision_organ_admin.Types of changes