Skip to content

Commit

Permalink
fix: dangling console logs
Browse files Browse the repository at this point in the history
  • Loading branch information
JustSamuel committed Nov 15, 2024
1 parent 1e9f137 commit 1cb0889
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 9 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/semantic-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,15 @@ jobs:
versioning:
uses: GEWIS/actions/.github/workflows/versioning.yml@v1

semantic-release:
uses: GEWIS/actions/.github/workflows/semantic-release.yml@v1
release:
uses: GEWIS/actions/.github/workflows/docker-release.yml@v1
needs: versioning
if: ${{ needs.versioning.outputs.next-version != '' }}
with:
projects: "['.']"
version: ${{ needs.versioning.outputs.next-version }}
docker_registry: "abc.docker-registry.gewis.nl"
docker_paths: "['eou/plankapi']"
docker-registry: "abc.docker-registry.gewis.nl"
docker-paths: "['eou/plankapi']"
github-registry: "true"
secrets:
REGISTRY_USERNAME: ${{ secrets.SVC_GH_ABCEOU_USERNAME }}
Expand Down
3 changes: 0 additions & 3 deletions .husky/pre-commit
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
#!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"

FORCE_COLOR=1
npx lint-staged
yarn build
3 changes: 1 addition & 2 deletions src/mailer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,6 @@ export default class Mailer {
continue;
}

console.error(message);
emails.unshift({
boardId: BigInt(plankaBoardId),
listId: plankaListId ? BigInt(plankaListId) : null,
Expand All @@ -148,7 +147,7 @@ export default class Mailer {

if (rejected.length !== 0) {
await this.client.mailboxOpen(`${this.ROOT_PATH}/IN`);
await this.rejectEmail(rejected.join(',')).catch((e) => console.error(e));
await this.rejectEmail(rejected.join(',')).catch((e) => this.logger.error(e));
await this.client.mailboxClose();
}

Expand Down

0 comments on commit 1cb0889

Please sign in to comment.