Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard/invoices): add ability to create invoices #304

Closed
wants to merge 8 commits into from

Conversation

CodeNamedRobin
Copy link
Contributor

Description

Adds invoice user table showing invoice users with outstanding debts, and allows for creating invoices. immediately.

Related issues/external references

Types of changes

  • New feature (non-breaking change which adds functionality)

@SuperVK
Copy link
Member

SuperVK commented Aug 15, 2024

image
Maybe I'm missing something, but this does not seem to work?

@CodeNamedRobin
Copy link
Contributor Author

image Maybe I'm missing something, but this does not seem to work?

Hi Victor,
It should work, but is dependent on if invoice users have outstanding debts. In the latest commit I have added a string if there are no outstanding debts by invoice users. Should clear the confusion.

@SuperVK
Copy link
Member

SuperVK commented Aug 18, 2024

I cannot see the string, there are translations missing as well. And I can't seem to link transactions to the invoice, or add some sort of amount to the invoice?

Again, maybe I'm missing something here though. But then the UX might need to be a bit clearer?

@SuperVK SuperVK linked an issue Aug 26, 2024 that may be closed by this pull request
@CodeNamedRobin
Copy link
Contributor Author

I cannot see the string, there are translations missing as well. And I can't seem to link transactions to the invoice, or add some sort of amount to the invoice?

Again, maybe I'm missing something here though. But then the UX might need to be a bit clearer?

Woops, I did not push the commit, should work now.

@CodeNamedRobin CodeNamedRobin force-pushed the feat/invoice-user-overview branch from e524dd1 to 02f685f Compare August 26, 2024 16:32
Comment on lines 103 to 115
yup.object({
for: yup.mixed<BaseUserResponse>().required(),
by: yup.mixed<BaseUserResponse>().required(),
addressee: yup.string().required(),
description: yup.string().required(),
date: yup.string().required(),
reference: yup.string().required(),
isCreditInvoice: yup.boolean().required().default(false),
street: yup.string().required(),
postalCode: yup.string().required(),
city: yup.string().required(),
country: yup.string().required(),
attention: yup.string().required(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attention is not required by the backend

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in latest commit.

@CodeNamedRobin CodeNamedRobin requested a review from SuperVK August 26, 2024 17:03
@CodeNamedRobin CodeNamedRobin force-pushed the feat/invoice-user-overview branch from e1fac3d to 4bfc202 Compare August 26, 2024 17:06
@SuperVK
Copy link
Member

SuperVK commented Aug 26, 2024

The translations are still missing.

I also at this point would advise against merging this with the state of the backend. We can't test the code because of the 501 it's throwing, and we expect some spec changes as well. It will just be broken code that needs to be rewritten either way. If you really want I won't stop you and we can still merge, but I think it will just be a very confusing lifeless components that are not much useful in this state.

@SuperVK
Copy link
Member

SuperVK commented Sep 12, 2024

Closed on request of Robin

@SuperVK SuperVK closed this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement overview of invoice accounts.
2 participants