-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dashboard/invoices): add ability to create invoices #304
Conversation
I cannot see the string, there are translations missing as well. And I can't seem to link transactions to the invoice, or add some sort of amount to the invoice? Again, maybe I'm missing something here though. But then the UX might need to be a bit clearer? |
Woops, I did not push the commit, should work now. |
e524dd1
to
02f685f
Compare
yup.object({ | ||
for: yup.mixed<BaseUserResponse>().required(), | ||
by: yup.mixed<BaseUserResponse>().required(), | ||
addressee: yup.string().required(), | ||
description: yup.string().required(), | ||
date: yup.string().required(), | ||
reference: yup.string().required(), | ||
isCreditInvoice: yup.boolean().required().default(false), | ||
street: yup.string().required(), | ||
postalCode: yup.string().required(), | ||
city: yup.string().required(), | ||
country: yup.string().required(), | ||
attention: yup.string().required(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Attention is not required by the backend
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in latest commit.
feat(dashboard/forms): added switchtoggle inputspan
…iew after completion
…nvoicecreatemodal
feat(dashboard/invoices): added string to invoice user table if there are no users with outstanding debts
…nd in create invoice form
e1fac3d
to
4bfc202
Compare
The translations are still missing. I also at this point would advise against merging this with the state of the backend. We can't test the code because of the 501 it's throwing, and we expect some spec changes as well. It will just be broken code that needs to be rewritten either way. If you really want I won't stop you and we can still merge, but I think it will just be a very confusing lifeless components that are not much useful in this state. |
Closed on request of Robin |
Description
Adds invoice user table showing invoice users with outstanding debts, and allows for creating invoices. immediately.
Related issues/external references
Types of changes