Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create monorepo #190

Closed
7 of 9 tasks
SuperVK opened this issue May 28, 2024 · 1 comment
Closed
7 of 9 tasks

Create monorepo #190

SuperVK opened this issue May 28, 2024 · 1 comment

Comments

@SuperVK
Copy link
Member

SuperVK commented May 28, 2024

Problem: frontend-common contains part of our codebase, but actually developing this code is almost impossible because it lives in a repository. For example stores, theming, fonts should probably live in the common, but right now is half in this repository and half in the frontend-common, depending on what people feel like.

Solution: Move everything to a monorepo.
This would create 3/(4) packages:

  • pos
  • frontend (this repository but needs a better name, because the whole monorepo is the frontend)
  • common
  • (theming, could also be part of the common)

Steps:

  • Rename https://github.com/GEWIS/sudosos-frontend-old
  • Rename sudosos-frontend and archive
  • Rename this repo to sudosos-frontend
  • Move everything into this repo
  • Archive the common and pos to preserve commit history
  • Create a top level package.json
  • Fix the actions
  • Move all the stores to the common
  • Move the theme to a central place
@SuperVK
Copy link
Member Author

SuperVK commented Jun 18, 2024

Closed in favor of #189

@SuperVK SuperVK closed this as completed Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant