Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] NFC Authentication #351

Open
2 of 5 tasks
Yoronex opened this issue Sep 23, 2024 · 2 comments
Open
2 of 5 tasks

[Feature] NFC Authentication #351

Yoronex opened this issue Sep 23, 2024 · 2 comments

Comments

@Yoronex
Copy link
Member

Yoronex commented Sep 23, 2024

Is this a feature for the SudoSOS point of sale or for the SudoSOS dashboard?

Both

What would you like?

Implementation of NFC Authentication on the frontend, which (preferably) includes an implementation in both the POS and the Dashboard. It contains the following functionality separated into standalone requirements. I have already made my personal prioritization, but feel free to change this.

Must-have

  • Allow users to log in on the POS by reading an NFC chip. This should be directly on the PIN login page, or by opening a dialog on the PIN login page.
  • Allow users to set their NFC Authentication after logging in on the POS.
  • Allow users to delete their NFC Authentication in the POS.

Should-have

  • Allow users to delete their NFC Authentication in the dashboard.

Could-have

  • Allow selecting users to create a transaction for by scanning an NFC chip. For example, instead of typing in one's name to find them in SudoSOS, a BAC member can scan their NFC card during the borrel to find them immediately.

As far as I am aware, the could-have was not supported in SuSOS. However, it might be nice to include it as an extra possible identification flow. Furthermore, it could also be used to support a SudoSOS-card system (where you get a bronze/silver/gold/platinum NFC card based on your SudoSOS spending).

Why is this needed?

People can then (finally) use their campus card or OV chipkaart to log in on the POS.

Other information

Current implemented endpoints on the backend should support all aforementioned requirements. There is currently no way to find users based on their NFC Authenticator, but you can simply use the authentication endpoint to see if any user exists. The authentication endpoint also returns the user, and not only a JWT token.

@JustSamuel
Copy link
Contributor

Current implemented endpoints on the backend should support all aforementioned requirements. There is currently no way to find users based on their NFC Authenticator, but you can simply use the authentication endpoint to see if any user exists. The authentication endpoint also returns the user, and not only a JWT token.

Returning a signed JWT token just to throw it a way seems iffy

@SuperVK
Copy link
Member

SuperVK commented Oct 19, 2024

I think @noelvandevrie started on this on the working moment, with the idea that registering can also be done via phones, as they also have NFC scanners built in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants