Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conditional LogZ calculation #150

Open
josephdviviano opened this issue Dec 7, 2023 · 1 comment
Open

Add conditional LogZ calculation #150

josephdviviano opened this issue Dec 7, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request high priority Let's do these first!
Milestone

Comments

@josephdviviano
Copy link
Collaborator

When using a conditional gflownet, we need the LogZ estimate (in algorithms such as TB) to be conditional, i.e., predicted from the state.

This means the logz parameter must not be constrained to be a single parameter.

Also, for conditional generation, sampling should accept an instance and/or iterator optionally, to condition on.

@josephdviviano josephdviviano added the enhancement New feature or request label Dec 7, 2023
@josephdviviano josephdviviano self-assigned this Dec 7, 2023
@josephdviviano josephdviviano added this to the V2 milestone Apr 16, 2024
@josephdviviano josephdviviano added the high priority Let's do these first! label Jun 12, 2024
@josephdviviano
Copy link
Collaborator Author

Addressed in #188

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request high priority Let's do these first!
Projects
None yet
Development

No branches or pull requests

1 participant