-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): Add workflow for the automatic config conversion #1656
Merged
MichaelsJP
merged 2 commits into
feat/config-cleanup-finalize
from
feat/config-conversion-workflow
Jan 30, 2024
Merged
feat(config): Add workflow for the automatic config conversion #1656
MichaelsJP
merged 2 commits into
feat/config-cleanup-finalize
from
feat/config-conversion-workflow
Jan 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelsJP
changed the title
feat: config @ arg > env > default locations, config info messages, d…
feat(config): Add workflow for the automatic config conversion
Jan 30, 2024
MichaelsJP
changed the title
feat(config): Add workflow for the automatic config conversion
feat: Add workflow for the automatic config conversion
Jan 30, 2024
MichaelsJP
changed the title
feat: Add workflow for the automatic config conversion
feat(config): Add workflow for the automatic config conversion
Jan 30, 2024
MichaelsJP
force-pushed
the
feat/config-conversion-workflow
branch
6 times, most recently
from
January 30, 2024 10:47
7ce519a
to
d931260
Compare
MichaelsJP
force-pushed
the
feat/config-conversion-workflow
branch
from
January 30, 2024 10:51
d931260
to
563ee79
Compare
MichaelsJP
force-pushed
the
feat/config-conversion-workflow
branch
from
January 30, 2024 11:57
bd53dab
to
5a3d808
Compare
takb
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The workflow is triggered on PRs for main and releases/** branches if the PR is set for review or synchronized.
MichaelsJP
force-pushed
the
feat/config-conversion-workflow
branch
from
January 30, 2024 13:01
52f8546
to
ed4358a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workflow is triggered on PRs for main and releases/** branches if the PR is set for review or synchronized.
Pull Request Checklist
have been resolved.
[Unreleased] heading.
along with a short description of what it is for, and documented this in the Pull Request (below).
(at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
importer etc.), I have generated longer distance routes for the affected profiles with different options
(avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
points generated from the current live ORS.
If there are differences then the reasoning for these MUST be documented in the pull request.
and why the change was needed.
Fixes # .
Information about the changes
Examples and reasons for differences between live ORS routes, and those generated from this pull request
Required changes to ors config (if applicable)