Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): Add workflow for the automatic config conversion #1656

Merged

Conversation

MichaelsJP
Copy link
Member

The workflow is triggered on PRs for main and releases/** branches if the PR is set for review or synchronized.

Pull Request Checklist

  • 1. I have rebased the latest version of the main branch into my feature branch and all conflicts
    have been resolved.
  • 2. I have added information about the change/addition to functionality to the CHANGELOG.md file under the
    [Unreleased] heading.
  • 3. I have documented my code using JDocs tags.
  • 4. I have removed unnecessary commented out code, imports and System.out.println statements.
  • 5. I have written JUnit tests for any new methods/classes and ensured that they pass.
  • 6. I have created API tests for any new functionality exposed to the API.
  • 7. If changes/additions are made to the ors-config.json file, I have added these to the ors config documentation
    along with a short description of what it is for, and documented this in the Pull Request (below).
  • 8. I have built graphs with my code of the Heidelberg.osm.gz file and run the api-tests with all test passing
  • 9. I have referenced the Issue Number in the Pull Request (if the changes were from an issue).
  • 10. For new features or changes involving building of graphs, I have tested on a larger dataset
    (at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
  • 11. For new features or changes involving the graphbuilding process (i.e. changing encoders, updating the
    importer etc.), I have generated longer distance routes for the affected profiles with different options
    (avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
    points generated from the current live ORS.
    If there are differences then the reasoning for these MUST be documented in the pull request.
  • 12. I have written in the Pull Request information about the changes made including their intended usage
    and why the change was needed.
  • 13. For changes touching the API documentation, I have tested that the API playground renders correctly.

Fixes # .

Information about the changes

  • Key functionality added:
  • Reason for change:

Examples and reasons for differences between live ORS routes, and those generated from this pull request

Required changes to ors config (if applicable)

@MichaelsJP MichaelsJP changed the title feat: config @ arg > env > default locations, config info messages, d… feat(config): Add workflow for the automatic config conversion Jan 30, 2024
@MichaelsJP MichaelsJP changed the title feat(config): Add workflow for the automatic config conversion feat: Add workflow for the automatic config conversion Jan 30, 2024
@github-actions github-actions bot removed the feature label Jan 30, 2024
@MichaelsJP MichaelsJP changed the title feat: Add workflow for the automatic config conversion feat(config): Add workflow for the automatic config conversion Jan 30, 2024
@github-actions github-actions bot added feature and removed feature labels Jan 30, 2024
@MichaelsJP MichaelsJP self-assigned this Jan 30, 2024
@MichaelsJP MichaelsJP marked this pull request as ready for review January 30, 2024 10:32
@github-actions github-actions bot added feature and removed feature labels Jan 30, 2024
@MichaelsJP MichaelsJP force-pushed the feat/config-conversion-workflow branch 6 times, most recently from 7ce519a to d931260 Compare January 30, 2024 10:47
@MichaelsJP MichaelsJP marked this pull request as draft January 30, 2024 10:48
@MichaelsJP MichaelsJP marked this pull request as ready for review January 30, 2024 10:48
@github-actions github-actions bot added feature and removed feature labels Jan 30, 2024
@MichaelsJP MichaelsJP force-pushed the feat/config-conversion-workflow branch from d931260 to 563ee79 Compare January 30, 2024 10:51
@MichaelsJP MichaelsJP marked this pull request as draft January 30, 2024 10:54
@MichaelsJP MichaelsJP marked this pull request as ready for review January 30, 2024 10:56
@github-actions github-actions bot added feature and removed feature labels Jan 30, 2024
@MichaelsJP MichaelsJP marked this pull request as draft January 30, 2024 11:30
@MichaelsJP MichaelsJP marked this pull request as ready for review January 30, 2024 11:31
@github-actions github-actions bot added feature and removed feature labels Jan 30, 2024
@MichaelsJP MichaelsJP marked this pull request as draft January 30, 2024 11:38
@MichaelsJP MichaelsJP marked this pull request as ready for review January 30, 2024 11:44
@github-actions github-actions bot added feature and removed feature labels Jan 30, 2024
@MichaelsJP MichaelsJP marked this pull request as draft January 30, 2024 11:54
@MichaelsJP MichaelsJP marked this pull request as ready for review January 30, 2024 11:54
@github-actions github-actions bot added feature and removed feature labels Jan 30, 2024
@MichaelsJP MichaelsJP force-pushed the feat/config-conversion-workflow branch from bd53dab to 5a3d808 Compare January 30, 2024 11:57
Copy link
Contributor

@takb takb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/workflows/config-conversion-automation.yml Outdated Show resolved Hide resolved
MichaelsJP and others added 2 commits January 30, 2024 14:01
The workflow is triggered on PRs for main and releases/** branches if the PR is set for review or synchronized.
@MichaelsJP MichaelsJP force-pushed the feat/config-conversion-workflow branch from 52f8546 to ed4358a Compare January 30, 2024 13:01
@MichaelsJP MichaelsJP merged commit e69071c into feat/config-cleanup-finalize Jan 30, 2024
4 checks passed
@MichaelsJP MichaelsJP deleted the feat/config-conversion-workflow branch January 30, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Awaiting release
Development

Successfully merging this pull request may close these issues.

2 participants