-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major update #12
Open
p-schaefer
wants to merge
87
commits into
GLFC-WET:main
Choose a base branch
from
p-schaefer:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Major update #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added target_uid to TEMP file names
clip_region was not written as TEMP-clip_region.shp when supplied as character pointing to a .tif file
replaced wbt_clip_raster_to_polygon() with terra::crop() because I believe its faster for large polygons
Removed raster::rastTmpFile() because there is no terra equivalent
modifications to terra function
set crs in a few more places
replaced Naflag with NAflag for terra::writeRaster
made terra temporary files save to unique folder to allow parallel processing
changed options to gdal in writeRaster
replaced wbt_clip_raster_to_polygon with terra::crop in flow_accum step
reprojected accum_clip again to match clip_dem
missed a method = "near"
forgot an '_' infront of one of the TEMP files
removed terraOptions (might not allow parallelizing the function)
minor fixes
Fixed an issue when target_o and target_s were given as characters
Minor edit
Removed restart
Minor fix
Merge branch 'main' of https://github.com/p-schaefer/hydroweight into main # Conflicts: # README.md
…e terra misses crs sometimes
…paths or SpatRaster objects
…ighted variables no longer calculated on lumped weights
…oducts for hw_attrib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated most functions in some major ways. All functions now allow parallel processing. Improved management of temporary files. Improved I/O with a dedicated function.