GPII-1939: Device Reporter reports screen resolutions #536
Conversation
- modified the Platform Reporter to be context aware. - modified the Platform Reporter to allow OS contexts to report additional specific information, e.g., screen resolutions.
Renmaed the function for getting the OS specific information and fixed spelling.
|
ok to test |
|
CI job passed. |
|
CI job passed. |
Also, merged upstream GPII master branch into GPII-1939.
|
CI job passed: https://ci.gpii.net/job/universal-tests/475/ |
|
ok to test |
|
CI job failed. Please visit http://lists.gpii.net/pipermail/ci/ for more details. |
|
CI job passed: https://ci.gpii.net/job/universal-tests/483/ |
|
CI job failed: https://ci.gpii.net/job/universal-tests/521/ |
|
ok to test |
|
CI job passed: https://ci.gpii.net/job/universal-tests/522/ |
|
CI job passed: https://ci.gpii.net/job/universal-tests/534/ |
|
CI job passed: https://ci.gpii.net/job/universal-tests/593/ |
|
CI job passed: https://ci.gpii.net/job/universal-tests/625/ |
|
This is still very relevant, but mothballed until we have an effectology that can be used to take this into account on matchmaking |
|
CI job passed: https://ci.gpii.net/job/universal-tests/692/ |
|
CI job passed: https://ci.gpii.net/job/universal-tests/709/ |
Merge upstream master branch into GPII-1939.
|
CI job failed: https://ci.gpii.net/job/universal-tests/755/ |
|
ok to test |
|
CI job passed: https://ci.gpii.net/job/universal-tests/756/ |
Merge upstream master branch into GPII-1939.
|
CI job passed: https://ci.gpii.net/job/universal-tests/770/ |
|
CI job passed: https://ci.gpii.net/job/universal-tests/794/ |
|
CI job failed: https://ci.gpii.net/job/universal-tests/803/ |
|
test this please |
|
CI job failed: https://ci.gpii.net/job/universal-tests/805/ |
|
Thanks @gtirloni but something odd is going on with the |
|
ok to test |
|
Looks like we were able to clone the repository this time: https://ci.gpii.net/job/universal-tests/808/console |
|
CI job passed: https://ci.gpii.net/job/universal-tests/808/ |
|
CI job failed: https://ci.gpii.net/job/universal-tests/827/ |
|
ok to test |
|
CI job passed: https://ci.gpii.net/job/universal-tests/828/ |
…esolutions Merged upstream master GPII branch 'gpii-master' into GPII-1939
|
CI job passed: https://ci.gpii.net/job/universal-tests/855/ |
|
CI job passed: https://ci.gpii.net/job/universal-tests/888/ |
|
CI job passed: https://ci.gpii.net/job/universal-tests/896/ |
@kaspermarkus, @javihernandez Here are the changes to the Device Reporter to have it add all available screen resolutions to its payload. Note that there are associated pull requests in the windows and linux branches, for doing the OS specific work.
@amb, FYI: this code replaces the "gpii.platform.native" grade with a context aware version of the platform reporter, as discussed in the pull request for the Process Reporter