Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GPII-3066: Stop acceptance tests crashing #177

Merged
merged 5 commits into from
Jun 8, 2018
Merged

GPII-3066: Stop acceptance tests crashing #177

merged 5 commits into from
Jun 8, 2018

Conversation

stegru
Copy link
Member

@stegru stegru commented May 31, 2018

Fixes a random crash.

@gpii-bot
Copy link

CI job failed: https://ci.gpii.net/job/windows-tests/499/

@stegru
Copy link
Member Author

stegru commented May 31, 2018

ok to test

Unrelated error:

npm ERR! code EINTEGRITY
npm ERR! sha1-0Ng2s0OqbbiMDez+rnHmJ11BQg4= integrity checksum failed when using sha1: wanted sha1-0Ng2s0OqbbiMDez+rnHmJ11BQg4= but got sha1-6PszGsIWbEqnxlBbBaCvjw8e6i0=. (7322378 bytes)

@gpii-bot
Copy link

CI job passed: https://ci.gpii.net/job/windows-tests/500/

JavierJF and others added 2 commits May 31, 2018 15:12
@JavierJF
GPII-3066: Used new Buffer API for memory initialization and removed …
a7a9766 
…ref() use in buffer type
@stegru
Merge pull request #3 from JavierJF/GPII-3066
6a92ea8 
GPII-3066: Fixed details to ensure memory safety
@gpii-bot
Copy link

CI job passed: https://ci.gpii.net/job/windows-tests/501/

@gpii-bot
Copy link

gpii-bot commented Jun 5, 2018

CI job failed: https://ci.gpii.net/job/windows-tests/516/

@stegru
Copy link
Member Author

stegru commented Jun 5, 2018

The last fail is unrelated.
ok to test

npm ERR! code EINTEGRITY
npm ERR! sha512-k6TIR8mTns3p35Q5knx+HZZpr3748S7nMiZqkAb4zg+xR1c2vRYSMegi5wWeYuBLe14AP0yTmamYu9eQsnCBDw== integrity checksum failed when using sha512: wanted sha512-k6TIR8mTns3p35Q5knx+HZZpr3748S7nMiZqkAb4zg+xR1c2vRYSMegi5wWeYuBLe14AP0yTmamYu9eQsnCBDw== but got sha512-OSSOtYx3iPgVkObZcAXMf8C9997ch+yI265PFFbE7IoqGwuzle83Q/gQG6qY2KbP2cdyZ5XXChHDo4fMrcsJOA==. (6413062 bytes)

npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\vagrant\AppData\Roaming\npm-cache\_logs\2018-06-05T10_19_48_150Z-debug.log
Installation process returned error code: 1
At C:\tmp\Provisioning.psm1:44 char:5
+     throw "Installation process returned error code: $($exitCode)"
+     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : OperationStopped: (Installation pr...d error code: 1:String) [], RuntimeException
    + FullyQualifiedErrorId : Installation process returned error code: 1

Build step 'Execute shell' marked build as failure
Finished: FAILURE

@gpii-bot
Copy link

gpii-bot commented Jun 5, 2018

CI job failed: https://ci.gpii.net/job/windows-tests/517/

@gpii-bot
Copy link

gpii-bot commented Jun 5, 2018

CI job passed: https://ci.gpii.net/job/windows-tests/518/

@stegru
Copy link
Member Author

stegru commented Jun 5, 2018

Acceptance tests now legitimately pass.

05:23:06.295:  jq: ***************
05:23:06.295:  jq: All tests concluded: 30/30 total passed in 57218ms - PASS
05:23:06.295:  jq: ***************
Sending e-mails to: [email protected]
Finished: SUCCESS

klown added a commit to klown/windows that referenced this pull request Jun 7, 2018
@klown
GPII-2404: Merge pull request GPII#177 from stegru/GPII-3066
a377929 
Stop acceptance tests crashing.
@amb26 amb26 mentioned this pull request Jun 7, 2018
Merged
@klown
Copy link
Member

klown commented Jun 7, 2018

Thanks @stegru for alerting me to these changes. It fixes acceptance test in CI for two of my pull requests, #121 and #134.

👍

@amb26 amb26 merged commit 0b5b7f6 into GPII:master Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stegru @gpii-bot @klown @amb26 @JavierJF