Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RGP/DevDriverComponents/listener/routerCore.cpp:401: bad expression ? #2

Open
dcb314 opened this issue Aug 16, 2018 · 1 comment
Open

Comments

@dcb314
Copy link

dcb314 commented Aug 16, 2018

Source code is

if (IsOutOfBandMessage(message) & !IsValidOutOfBandMessage(message))

Maybe better code

if (IsOutOfBandMessage(message) && !IsValidOutOfBandMessage(message))

@ahosier
Copy link
Contributor

ahosier commented Sep 7, 2018

Hi,

I spoke to the team responsible for this and they say that this code is legit; apparently it’s more optimal to use this rather than the logical AND. It has the same effect but it’s not really intuitive. Is it causing a compiler warning? If so it should be fixed. At the very least, it should be commented to indicate that it is intended behavior. I'll update this post when the fix has been checked in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants