VK_LAYER_RGA_pipeline_extraction layer crashes on program exit

[dan5sch]

On Ubuntu 20.04, enabling the VK_LAYER_RGA_pipeline_extraction layer from RGA release 2.6.2 results in a crash with the following error when I close the Vulkan application for which I enabled the layer:

/home/jenkins/workspace/RGA-Layer/Fossilize/rga/Vulkan/Src/Converters/rgFossilizeConverter.cpp:913: static bool rgFossilizeConverter::Convert(const Document&, const string&, bool, const std::map<unsigned int, VkShaderModuleCreateInfo>&, std::vector<std::__cxx11::basic_string<char> >&, const std::map<long unsigned int, std::__cxx11::basic_string<char> >&): Assertion 'ret' failed.

The Vulkan application does run normally until I exit the program. Setting ENABLE_RGA_PIPELINE_EXTRACTION_LAYER=1 is sufficient to produce the crash, even if RGA_LAYER_OUTPUT_PATH is unset.

Version info:

• Ubuntu 20.04.4
• RGA release containing the layer: 2.6.2
• amdgpu-pro-core package: 22.20-1438746~20.04
• vulkan-amdgpu-pro package: 22.20-1438746~20.04
• vulkan-sdk package: 1.3.216.0~rc2-1lunarg20.04-1

Separately, the layer files and the install process provided by the rga_layer_install script presented multiple issues:

• The provided .json file for the layer lists the layer name as libVK_LAYER_RGA_pipeline_extraction (note the lib prefix). This causes the SDK's Vulkan Configurator to complain on startup that the layer is malformed. Manually removing the "lib" prefix from the name field fixed this issue.
• The .json file lists an api_version of 1.0.70, causing the Vulkan Loader to silently ignore the layer for applications using a newer API version. At first I thought the file wasn't even being found at its install location (~/.local/share/vulkan/implicit_layer.d), but it turns out that ignoring older-version layers is intended behavior. Manually updating the version to higher than my application's requested Vulkan API version fixed the issue. This was a "fun" one to track down.