Build: Remove default TMP_BUILD_DIR
#82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirenradia
force-pushed
the
enhancement/common_tmp_build_dir
branch
from
596c128 to
623c99c
Compare
This was referenced Dec 23, 2024
julianakwan
reviewed
Jan 7, 2025
I think this will help with #68. The disadvantage (and the reason I bothered to set this default in the first place) is that consecutive builds of different AMReX executables (e.g. two different examples) will be slower. To mitigate this, users should use Ccache. I will add this to the CI in a separate PR.
mirenradia
force-pushed
the
enhancement/common_tmp_build_dir
branch
from
623c99c to
1444aa8
Compare
julianakwan
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this will help with #68. The disadvantage (and the reason I bothered to set this default in the first place) is that consecutive builds of different AMReX executables (e.g. two different examples) will be slower. To mitigate this, users should use Ccache which I have added to the README. I will make a separate PR to add Ccache to the CI workflows.