From a9fb85972c871d470949af8b6ad815ce1e6eb56a Mon Sep 17 00:00:00 2001 From: AJ Farkas Date: Thu, 24 Oct 2024 15:20:28 -0400 Subject: [PATCH 1/6] LG-14588 update axe wcag tags --- _includes/accordion.html | 4 +-- _includes/hero.html | 12 +++++++++ _layouts/base.html | 12 --------- _layouts/documentation.html | 1 + _layouts/home.html | 1 + assets/scss/main.css.scss | 15 +++++++++++ package-lock.json | 47 ++++++++++++++++++---------------- package.json | 2 +- spec/e2e/accessibility.test.js | 10 +++++++- 9 files changed, 66 insertions(+), 38 deletions(-) create mode 100644 _includes/hero.html diff --git a/_includes/accordion.html b/_includes/accordion.html index 0c54308d..50516683 100644 --- a/_includes/accordion.html +++ b/_includes/accordion.html @@ -15,6 +15,6 @@

{{ include.title }}

-
+ \ No newline at end of file +
diff --git a/_includes/hero.html b/_includes/hero.html new file mode 100644 index 00000000..94260679 --- /dev/null +++ b/_includes/hero.html @@ -0,0 +1,12 @@ +{% if page.lead %} +
+
+
+
+

{{ page.title }}

+
{{ page.lead | markdownify }}
+
+
+
+
+{% endif %} diff --git a/_layouts/base.html b/_layouts/base.html index 48589ad5..bca9cf61 100644 --- a/_layouts/base.html +++ b/_layouts/base.html @@ -133,18 +133,6 @@ - {% if page.lead %} -
-
-
-
-

{{ page.title }}

-
{{ page.lead | markdownify }}
-
-
-
-
- {% endif %} {{ content }} diff --git a/_layouts/documentation.html b/_layouts/documentation.html index e11bb95a..35d58db5 100644 --- a/_layouts/documentation.html +++ b/_layouts/documentation.html @@ -3,6 +3,7 @@ ---
+ {% include hero.html %}
{% if page.sidenav %}
diff --git a/_layouts/home.html b/_layouts/home.html index 2ee81d54..fda6b4f0 100644 --- a/_layouts/home.html +++ b/_layouts/home.html @@ -3,5 +3,6 @@ ---
+ {% include hero.html %} {{ content }}
diff --git a/assets/scss/main.css.scss b/assets/scss/main.css.scss index f6d8d96d..a92921ab 100644 --- a/assets/scss/main.css.scss +++ b/assets/scss/main.css.scss @@ -22,6 +22,15 @@ main.usa-layout-docs { word-wrap: break-word; } +main#main-content { + padding-top: 0; + border-top: none; +} + +.usa-section > .lg-hero { + margin-bottom: 2rem; +} + .dev-doc-row { border-top: 1px solid #CEDCED; padding-bottom: 2rem; @@ -154,6 +163,12 @@ button.code-button:hover { height: 1.3rem; } +@media (min-width: 640px) { + .usa-section > .lg-hero { + margin-bottom: 4rem; + } +} + @media (min-width: 1024px) { .code-snippet-column { background-color: transparent; diff --git a/package-lock.json b/package-lock.json index 86dfe77d..d36b86f8 100644 --- a/package-lock.json +++ b/package-lock.json @@ -14,7 +14,7 @@ }, "devDependencies": { "@18f/eslint-plugin-identity": "^2.0.0", - "@axe-core/puppeteer": "^4.8.5", + "@axe-core/puppeteer": "^4.10.0", "eslint": "^8.52.0", "eslint-plugin-import": "^2.29.0", "eslint-plugin-prettier": "^5.0.1", @@ -115,12 +115,13 @@ "integrity": "sha512-1CJwTd6B6XDb6HETcHMwjRmQLQi2FgjM1rYUO6wf1yizKVPC9V66vmvVCtgePMzWmhsLqdhOPLWt+fNvG46FoA==" }, "node_modules/@axe-core/puppeteer": { - "version": "4.8.5", - "resolved": "https://registry.npmjs.org/@axe-core/puppeteer/-/puppeteer-4.8.5.tgz", - "integrity": "sha512-lwr1pXnB2Jn+st5DfTosu0n/t5P90Sw4dzF2f54czguuWHNnqaMRQxial5VkyTGFu/ESQLXFoKwfvu1kKPI3WQ==", + "version": "4.10.0", + "resolved": "https://registry.npmjs.org/@axe-core/puppeteer/-/puppeteer-4.10.0.tgz", + "integrity": "sha512-riTHfL/kvDmhgaZtv3mHWYLeCVridlgRjt8LPxzNNIGTbUb5MvI4RQUR5ymKwXSlFwW/3EXxZiggPaARedWCRQ==", "dev": true, + "license": "MPL-2.0", "dependencies": { - "axe-core": "~4.8.4" + "axe-core": "~4.10.0" }, "engines": { "node": ">=6.4.0" @@ -770,10 +771,11 @@ } }, "node_modules/axe-core": { - "version": "4.8.4", - "resolved": "https://registry.npmjs.org/axe-core/-/axe-core-4.8.4.tgz", - "integrity": "sha512-CZLSKisu/bhJ2awW4kJndluz2HLZYIHh5Uy1+ZwDRkJi69811xgIXXfdU9HSLX0Th+ILrHj8qfL/5wzamsFtQg==", + "version": "4.10.2", + "resolved": "https://registry.npmjs.org/axe-core/-/axe-core-4.10.2.tgz", + "integrity": "sha512-RE3mdQ7P3FRSe7eqCWoeQ/Z9QXrtniSjp1wUjt5nRC3WIpz5rSCve6o3fsZ2aCpJtrZjSZgjwXAoTO5k4tEI0w==", "dev": true, + "license": "MPL-2.0", "engines": { "node": ">=4" } @@ -1042,9 +1044,9 @@ } }, "node_modules/caniuse-lite": { - "version": "1.0.30001589", - "resolved": "https://registry.npmjs.org/caniuse-lite/-/caniuse-lite-1.0.30001589.tgz", - "integrity": "sha512-vNQWS6kI+q6sBlHbh71IIeC+sRwK2N3EDySc/updIGhIee2x5z00J4c1242/5/d6EpEMdOnk/m+6tuk4/tcsqg==", + "version": "1.0.30001669", + "resolved": "https://registry.npmjs.org/caniuse-lite/-/caniuse-lite-1.0.30001669.tgz", + "integrity": "sha512-DlWzFDJqstqtIVx1zeSpIMLjunf5SmwOw0N2Ck/QSQdS8PLS4+9HrLaYei4w8BIAL7IB/UEDu889d8vhCTPA0w==", "funding": [ { "type": "opencollective", @@ -1058,7 +1060,8 @@ "type": "github", "url": "https://github.com/sponsors/ai" } - ] + ], + "license": "CC-BY-4.0" }, "node_modules/chalk": { "version": "4.1.2", @@ -5684,12 +5687,12 @@ "integrity": "sha512-1CJwTd6B6XDb6HETcHMwjRmQLQi2FgjM1rYUO6wf1yizKVPC9V66vmvVCtgePMzWmhsLqdhOPLWt+fNvG46FoA==" }, "@axe-core/puppeteer": { - "version": "4.8.5", - "resolved": "https://registry.npmjs.org/@axe-core/puppeteer/-/puppeteer-4.8.5.tgz", - "integrity": "sha512-lwr1pXnB2Jn+st5DfTosu0n/t5P90Sw4dzF2f54czguuWHNnqaMRQxial5VkyTGFu/ESQLXFoKwfvu1kKPI3WQ==", + "version": "4.10.0", + "resolved": "https://registry.npmjs.org/@axe-core/puppeteer/-/puppeteer-4.10.0.tgz", + "integrity": "sha512-riTHfL/kvDmhgaZtv3mHWYLeCVridlgRjt8LPxzNNIGTbUb5MvI4RQUR5ymKwXSlFwW/3EXxZiggPaARedWCRQ==", "dev": true, "requires": { - "axe-core": "~4.8.4" + "axe-core": "~4.10.0" } }, "@babel/code-frame": { @@ -6180,9 +6183,9 @@ "dev": true }, "axe-core": { - "version": "4.8.4", - "resolved": "https://registry.npmjs.org/axe-core/-/axe-core-4.8.4.tgz", - "integrity": "sha512-CZLSKisu/bhJ2awW4kJndluz2HLZYIHh5Uy1+ZwDRkJi69811xgIXXfdU9HSLX0Th+ILrHj8qfL/5wzamsFtQg==", + "version": "4.10.2", + "resolved": "https://registry.npmjs.org/axe-core/-/axe-core-4.10.2.tgz", + "integrity": "sha512-RE3mdQ7P3FRSe7eqCWoeQ/Z9QXrtniSjp1wUjt5nRC3WIpz5rSCve6o3fsZ2aCpJtrZjSZgjwXAoTO5k4tEI0w==", "dev": true }, "axobject-query": { @@ -6368,9 +6371,9 @@ "dev": true }, "caniuse-lite": { - "version": "1.0.30001589", - "resolved": "https://registry.npmjs.org/caniuse-lite/-/caniuse-lite-1.0.30001589.tgz", - "integrity": "sha512-vNQWS6kI+q6sBlHbh71IIeC+sRwK2N3EDySc/updIGhIee2x5z00J4c1242/5/d6EpEMdOnk/m+6tuk4/tcsqg==" + "version": "1.0.30001669", + "resolved": "https://registry.npmjs.org/caniuse-lite/-/caniuse-lite-1.0.30001669.tgz", + "integrity": "sha512-DlWzFDJqstqtIVx1zeSpIMLjunf5SmwOw0N2Ck/QSQdS8PLS4+9HrLaYei4w8BIAL7IB/UEDu889d8vhCTPA0w==" }, "chalk": { "version": "4.1.2", diff --git a/package.json b/package.json index 7fd0250e..59d65213 100644 --- a/package.json +++ b/package.json @@ -25,7 +25,7 @@ }, "devDependencies": { "@18f/eslint-plugin-identity": "^2.0.0", - "@axe-core/puppeteer": "^4.8.5", + "@axe-core/puppeteer": "^4.10.0", "eslint": "^8.52.0", "eslint-plugin-import": "^2.29.0", "eslint-plugin-prettier": "^5.0.1", diff --git a/spec/e2e/accessibility.test.js b/spec/e2e/accessibility.test.js index b1fe545e..b53f92cf 100644 --- a/spec/e2e/accessibility.test.js +++ b/spec/e2e/accessibility.test.js @@ -44,7 +44,15 @@ describe('accessibility', () => { test(path, async () => { const page = await browser.newPage(); await page.goto(`http://localhost:${port}${path}`); - const results = await new AxePuppeteer(page).withTags(['wcag2a', 'wcag2aa']).analyze(); + const results = await new AxePuppeteer(page).withTags([ + 'wcag2a', + 'wcag2aa', + 'wcag21a', + 'wcag21aa', + 'wcag22a', + 'wcag22aa', + 'best-practice', + ]).analyze(); await page.close(); assert.deepStrictEqual(results.violations, []); From 46d8d7b132f2b63ad26f83ab903df7e626b7234d Mon Sep 17 00:00:00 2001 From: AJ Farkas Date: Thu, 24 Oct 2024 17:08:59 -0400 Subject: [PATCH 2/6] LG-14588 only heading-order left --- _includes/hero.html | 12 --- .../snippets/auth_content/service_levels.md | 2 +- _layouts/base.html | 18 +++- _layouts/documentation.html | 1 - _layouts/home.html | 1 - _pages/oidc/authorization.md | 2 +- _pages/saml/authentication.md | 2 +- _pages/support.md | 100 +++++++++--------- assets/scss/main.css.scss | 19 +--- 9 files changed, 72 insertions(+), 85 deletions(-) delete mode 100644 _includes/hero.html diff --git a/_includes/hero.html b/_includes/hero.html deleted file mode 100644 index 94260679..00000000 --- a/_includes/hero.html +++ /dev/null @@ -1,12 +0,0 @@ -{% if page.lead %} -
-
-
-
-

{{ page.title }}

-
{{ page.lead | markdownify }}
-
-
-
-
-{% endif %} diff --git a/_includes/snippets/auth_content/service_levels.md b/_includes/snippets/auth_content/service_levels.md index 5e64dde7..e9a5d157 100644 --- a/_includes/snippets/auth_content/service_levels.md +++ b/_includes/snippets/auth_content/service_levels.md @@ -4,7 +4,7 @@ - **`http://idmanagement.gov/ns/assurance/ial/1`** Basic identity assurance, does not require identity verification (this is the most common value). - **`http://idmanagement.gov/ns/assurance/ial/2`** - Requires that the user has gone through identity verification* + Requires that the user has gone through identity verification* {% endcapture %}
{{ type_of_service | markdownify }} diff --git a/_layouts/base.html b/_layouts/base.html index bca9cf61..4d1923af 100644 --- a/_layouts/base.html +++ b/_layouts/base.html @@ -93,7 +93,7 @@
{{ content }} diff --git a/_layouts/documentation.html b/_layouts/documentation.html index 35d58db5..e11bb95a 100644 --- a/_layouts/documentation.html +++ b/_layouts/documentation.html @@ -3,7 +3,6 @@ ---
- {% include hero.html %}
{% if page.sidenav %}
diff --git a/_layouts/home.html b/_layouts/home.html index fda6b4f0..2ee81d54 100644 --- a/_layouts/home.html +++ b/_layouts/home.html @@ -3,6 +3,5 @@ ---
- {% include hero.html %} {{ content }}
diff --git a/_pages/oidc/authorization.md b/_pages/oidc/authorization.md index 9d4ceab1..1aeac70f 100644 --- a/_pages/oidc/authorization.md +++ b/_pages/oidc/authorization.md @@ -119,7 +119,7 @@ In an **unsuccessful authorization**, the URI will contain the parameters `error

acr_values

- The Authentication Context Class Reference requests can be used to specify the type of service level* or the AAL (Authentication Assurance Level) for the user. These and the scope determine which user attributes will be available in the user info response. + The Authentication Context Class Reference requests can be used to specify the type of service level* or the AAL (Authentication Assurance Level) for the user. These and the scope determine which user attributes will be available in the user info response.

Multiple values can be joined with a space (before being URI-escaped in the final URL).

diff --git a/_pages/saml/authentication.md b/_pages/saml/authentication.md index a4cfd060..42345d9e 100644 --- a/_pages/saml/authentication.md +++ b/_pages/saml/authentication.md @@ -31,7 +31,7 @@ sidenav: `:SAML_REQUEST = urlEncode(base64(deflate(payload)))` {% endcapture %} {% capture saml_tag %} -The `` tags (nested under `//samlp:AuthnRequest/samlp:RequestedAuthnContext/`) specify the type of identity verification*, AAL (Authentication Assurance Level) and attributes requested. +The `` tags (nested under `//samlp:AuthnRequest/samlp:RequestedAuthnContext/`) specify the type of identity verification*, AAL (Authentication Assurance Level) and attributes requested. {% endcapture %} {% capture attributes %} To request specific attributes, list them (comma-separated) as the query parameter for `http://idmanagement.gov/ns/requested_attributes?ReqAttr=`. See the [user attributes]({{ '/attributes/' | prepend: site.baseurl }}) for the list of attributes that can be requested. diff --git a/_pages/support.md b/_pages/support.md index 535f54c2..2942f3cc 100644 --- a/_pages/support.md +++ b/_pages/support.md @@ -17,7 +17,7 @@ sidenav: - text: Contacting Partner Support href: "#contacting-partner-support" --- -### Login.gov support desk +## Login.gov support desk If you have technical questions that are not covered by these FAQ's, submit a ticket to the -

+

-

+

@@ -47,52 +47,52 @@ If you have technical questions that are not covered by these FAQ's, submit a ti

-

+

-

+
-
+
-

+

-

+
-
+
-

+

-

+
-
+
-

+

-

+
-
+
-

+

-

+
-
+
-

+

-

+
-
+
-

+

-

+
-
+
-

+

-

+
-
+
-

+

-

+
-
+
-

+

-

+
-
+
-

+

-

+
-
+
-

+

-

+
-
+