Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create end point login #15 #33

Merged
merged 7 commits into from
Oct 31, 2021
Merged

create end point login #15 #33

merged 7 commits into from
Oct 31, 2021

Conversation

mohammedsalah7
Copy link
Collaborator

No description provided.

@mohammedsalah7 mohammedsalah7 self-assigned this Oct 28, 2021
Mu7ammadAbed
Mu7ammadAbed requested changes Oct 29, 2021
View reviewed changes
server/app.js Outdated Show resolved Hide resolved
server/controllers/users/login.js Show resolved Hide resolved
server/controllers/users/login.js Outdated Show resolved Hide resolved
server/test/index.test.js Outdated Show resolved Hide resolved
ElhamFadel
ElhamFadel previously approved these changes Oct 29, 2021
View reviewed changes
Mu7ammadAbed
Mu7ammadAbed requested changes Oct 30, 2021
View reviewed changes
Copy link
Member

@Mu7ammadAbed Mu7ammadAbed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to update your branch to the latest development version
git pull origin development
and there's an env requiring in the connection file you have to keep it there

server/controllers/users/login.js Outdated Show resolved Hide resolved
server/controllers/users/login.js Outdated Show resolved Hide resolved
server/controllers/users/login.js Outdated Show resolved Hide resolved
server/controllers/users/login.js Outdated Show resolved Hide resolved
@Mu7ammadAbed
Copy link
Member

You need to update the branch with the development and resolve your conflicts, be aware that there are some changes with the routes file.

Mu7ammadAbed
Mu7ammadAbed previously approved these changes Oct 31, 2021
View reviewed changes
ElhamFadel
ElhamFadel previously approved these changes Oct 31, 2021
View reviewed changes
@mohammedsalah7 mohammedsalah7 linked an issue Oct 31, 2021 that may be closed by this pull request
POST | /login #15
Closed
@Mu7ammadAbed Mu7ammadAbed dismissed stale reviews from ElhamFadel and themself via dffb4ef October 31, 2021 14:03
@ElhamFadel ElhamFadel merged commit 3f896e8 into development Oct 31, 2021
@ElhamFadel ElhamFadel deleted the 15-login branch October 31, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElhamFadel ElhamFadel ElhamFadel approved these changes

@muhammadharoun muhammadharoun muhammadharoun approved these changes

@Mu7ammadAbed Mu7ammadAbed Mu7ammadAbed approved these changes

Assignees

@mohammedsalah7 mohammedsalah7

Labels
Awaiting Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

POST | /login
4 participants
@mohammedsalah7 @Mu7ammadAbed @muhammadharoun @ElhamFadel