Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review comments #74

Open
justinwiley opened this issue Oct 8, 2019 · 0 comments
Open

Review comments #74

justinwiley opened this issue Oct 8, 2019 · 0 comments

Comments

@justinwiley
Copy link

Hello Team,

I've really enjoyed following your project, and I am very impressed by your hard work, and what I've seen you accomplish.

I wanted to leave some brief feedback from you based on the pull-requests I've reviewed.

Some general thoughts I can share:

  • Don’t be afraid to communicate and ask questions. The more questions you ask now, the less time you will spend later
  • Learn and write tests for your code. While tests take time, they will let you find bugs faster and improve code over time, which is crucial to running a large, commercial project (https://codeburst.io/test-driven-development-with-jest-37e82ddb3989)
  • Learn and use typical design patterns (https://sourcemaking.com/design_patterns). Most of the problems you will encounter have been solved by others before, patterns let you leverage them
  • Take care of your customers by giving them clear error messages. If they can’t figure out how to fill out a form correctly, they can’t pay you! :)

Please contact me with any questions or comments, or suggestions on how I can better help.

I'm excited to see what you come up with next!

Justin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant