Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Names #40

Open
IsraaSulaiman opened this issue Jul 25, 2019 · 0 comments
Open

File Names #40

IsraaSulaiman opened this issue Jul 25, 2019 · 0 comments

Comments

@IsraaSulaiman
Copy link

  1. In src, you named the file where you handled all routes by 'hanlderData'. I think it would be better if you named it handlers.
  2. In the public folder, you have request.js, but this file does not only include the xhr request; it also includes handling events and dom manipulation. Either change the name to be relevant to the content or move dom manipulations to the dom file. I am with the second option.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant