New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PULL REQUEST #65

Open

Fatmasiam opened this issue Oct 29, 2019 · 1 comment

Assignees

Labels

Collaborator

Fatmasiam commented Oct 29, 2019 •

edited

Loading

When you open the `PR` :

add it to the related project.
remove any console.log except the console.log on the error file.
remove unrelated files
make sure that your branch is up to date with master
make sure that is working locally
make sure that there are no ESlint issues in your code
code is consistent with an agreed team style
write a description for what the component or page do
write how to test your component

-- put `in progress` label when you are still working on the PR.
or make it draft

AND KEEP IN YOUR MIND THAT THE ISSUES IT IS REFERENCE

Its didn't take our time to neglect it

The text was updated successfully, but these errors were encountered:

Fatmasiam added the Pull Request label

Fatmasiam assigned AlaaTaima, fares98, yosefanajjar and alaa-yasin

Fatmasiam pinned this issue

Fatmasiam mentioned this issue

13 server error #70

Merged

Collaborator Author

Fatmasiam commented Oct 30, 2019

@yosefalnajjarofficial @alaa-yasin @AlaaTaima @fares98

follow this issue on the `PR`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment