You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Due to some confusion on my part, I opened a PR a couple days ago that updated the pre-commit & linting logic. Ali rightly let me know that, I should leave the coding to y'all, so I closed it. But thank you to those of you who, despite my misstep, honored it with an approval 🙏
Background
My initial interest was to have auto-formatting run on the CSS as well as the JS. The main reason I thought that would be cool was to help reduce formatting-related change-requests in PRs 1
In that process, I saw something that I actually ran into on a project at my job earlier this year, where pre-commit scripts were running on all project files, instead of the ones in the changeset. In the project at my job, it was causing huge lag when trying to commit, but the shrinc codebase isn't overwhelmingly large, so really there was no practical issue with it.
Current Sitch
I thought I'd open this issue, partly to clarify, but also in case anybody was interested in taking it to the finish line. I think it was pretty close, but it's the type of thing that might not be very high-value compared with other priorities, and definitley no worries if this doesn't get any action.
Anyway, you guys rock. I'm a big fan. Thanks for your consideration 👍
1 PRs can be realllll daggers to dev velocity, especially on super large teams. That's why auto formatting and lint rules are sooooo dope. Fun Fact: Some teams don't even use PRs, and just use pair-programming and CI tests/automation for validation.
The text was updated successfully, but these errors were encountered:
leggomuhgreggo
changed the title
Linting + Pre-commit Hook & Bonus Rant About PRs 😄
Linting + Pre-commit Hook
Nov 7, 2019
Preface
Due to some confusion on my part, I opened a PR a couple days ago that updated the pre-commit & linting logic. Ali rightly let me know that, I should leave the coding to y'all, so I closed it. But thank you to those of you who, despite my misstep, honored it with an approval 🙏
Background
My initial interest was to have auto-formatting run on the CSS as well as the JS. The main reason I thought that would be cool was to help reduce formatting-related change-requests in PRs 1
In that process, I saw something that I actually ran into on a project at my job earlier this year, where pre-commit scripts were running on all project files, instead of the ones in the changeset. In the project at my job, it was causing huge lag when trying to commit, but the
shrinc
codebase isn't overwhelmingly large, so really there was no practical issue with it.Current Sitch
I thought I'd open this issue, partly to clarify, but also in case anybody was interested in taking it to the finish line. I think it was pretty close, but it's the type of thing that might not be very high-value compared with other priorities, and definitley no worries if this doesn't get any action.
Anyway, you guys rock. I'm a big fan. Thanks for your consideration 👍
1 PRs can be realllll daggers to dev velocity, especially on super large teams. That's why auto formatting and lint rules are sooooo dope. Fun Fact: Some teams don't even use PRs, and just use pair-programming and CI tests/automation for validation.
The text was updated successfully, but these errors were encountered: