Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting + Pre-commit Hook #140

Open
leggomuhgreggo opened this issue Nov 7, 2019 · 0 comments
Open

Linting + Pre-commit Hook #140

leggomuhgreggo opened this issue Nov 7, 2019 · 0 comments

Comments

@leggomuhgreggo
Copy link

leggomuhgreggo commented Nov 7, 2019

Preface

Due to some confusion on my part, I opened a PR a couple days ago that updated the pre-commit & linting logic. Ali rightly let me know that, I should leave the coding to y'all, so I closed it. But thank you to those of you who, despite my misstep, honored it with an approval 🙏

Background

My initial interest was to have auto-formatting run on the CSS as well as the JS. The main reason I thought that would be cool was to help reduce formatting-related change-requests in PRs 1

In that process, I saw something that I actually ran into on a project at my job earlier this year, where pre-commit scripts were running on all project files, instead of the ones in the changeset. In the project at my job, it was causing huge lag when trying to commit, but the shrinc codebase isn't overwhelmingly large, so really there was no practical issue with it.

Current Sitch

I thought I'd open this issue, partly to clarify, but also in case anybody was interested in taking it to the finish line. I think it was pretty close, but it's the type of thing that might not be very high-value compared with other priorities, and definitley no worries if this doesn't get any action.

Anyway, you guys rock. I'm a big fan. Thanks for your consideration 👍


1 PRs can be realllll daggers to dev velocity, especially on super large teams. That's why auto formatting and lint rules are sooooo dope. Fun Fact: Some teams don't even use PRs, and just use pair-programming and CI tests/automation for validation.

@leggomuhgreggo leggomuhgreggo changed the title Linting + Pre-commit Hook & Bonus Rant About PRs 😄 Linting + Pre-commit Hook Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant