New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Authentication #51

Open

AlaaTaima opened this issue Mar 4, 2020 · 0 comments

Labels

review

AlaaTaima commented Mar 4, 2020

PalB/server/controllers/hash.js

Lines 5 to 9 in 9ded714

    
           const hashPassword = (password) => bcrypt.hash(password, 10); 
        
           const comparePasswords = (password, hash) => bcrypt.compare(password, hash); 
        
           const generateToken = (data) => new Promise((resolve, reject) => {

Why you didn't use them to hash password and cookie ????!

AlaaTaima added the review label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment