Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

25 PUT alumni/:studentId #60

Merged
merged 10 commits into from
Apr 3, 2020
Merged

25 PUT alumni/:studentId #60

merged 10 commits into from
Apr 3, 2020

Conversation

rehabas
Copy link
Collaborator

@rehabas rehabas commented Apr 2, 2020 •
edited by ranasobeid95
Loading

#25

  • Create a query for put an alumni.
  • Create middleware for this query function.
  • Handle route PUT api/v1/alumni/:studentId .
  • Make tests for this route.

@rehabas rehabas added Awaiting Review This PR is ready and waiting for review Backend labels Apr 2, 2020
@rehabas rehabas self-assigned this Apr 2, 2020
@rehabas rehabas changed the title 25 put alumni 25 PUT api/v1/alumni/:studentId Apr 2, 2020
@rehabas rehabas changed the title 25 PUT api/v1/alumni/:studentId 25 PUT alumni/:studentId Apr 2, 2020
MohammedAlghazali
MohammedAlghazali previously approved these changes Apr 2, 2020
View reviewed changes
Copy link
Member

@MohammedAlghazali MohammedAlghazali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Work

AlaaSaadeddin
AlaaSaadeddin previously approved these changes Apr 2, 2020
View reviewed changes
@rehabas rehabas dismissed stale reviews from MohammedAlghazali and AlaaSaadeddin via a5fc51b April 2, 2020 21:27
Mu7ammadAbed
Mu7ammadAbed previously approved these changes Apr 2, 2020
View reviewed changes
AlaaSaadeddin
AlaaSaadeddin previously approved these changes Apr 2, 2020
View reviewed changes
@ranasobeid95 ranasobeid95 added Approved and removed Awaiting Review This PR is ready and waiting for review labels Apr 3, 2020
@Mu7ammadAbed Mu7ammadAbed merged commit ef66b41 into master Apr 3, 2020
@Mu7ammadAbed Mu7ammadAbed deleted the 25-put-alumni branch April 3, 2020 13:28
@ranasobeid95 ranasobeid95 added Done and removed Approved labels Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MohammedAlghazali MohammedAlghazali MohammedAlghazali approved these changes

@ranasobeid95 ranasobeid95 ranasobeid95 approved these changes

@Mu7ammadAbed Mu7ammadAbed Mu7ammadAbed approved these changes

@AlaaSaadeddin AlaaSaadeddin Awaiting requested review from AlaaSaadeddin

Assignees

@rehabas rehabas

Labels
Backend Done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rehabas @AlaaSaadeddin @Mu7ammadAbed @ranasobeid95 @MohammedAlghazali