Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get alumin for cohort #61

Merged
merged 9 commits into from
Apr 4, 2020
Merged

get alumin for cohort #61

merged 9 commits into from
Apr 4, 2020

Conversation

MohammedAlghazali
Copy link
Member

@MohammedAlghazali MohammedAlghazali commented Apr 2, 2020 •
edited
Loading

relates #27

  • change route from /alumni/:cohortId to /alumni/cohorts/:cohortId
  • make query to get all alumni from specific cohort
  • make function nedded for this route
  • make test neded for this route
    145
  • send request by postman
    146
    147

@MohammedAlghazali MohammedAlghazali added Awaiting Review This PR is ready and waiting for review Backend labels Apr 2, 2020
@MohammedAlghazali MohammedAlghazali self-assigned this Apr 2, 2020
AlaaSaadeddin
AlaaSaadeddin previously approved these changes Apr 2, 2020
View reviewed changes
rehabas
rehabas previously approved these changes Apr 3, 2020
View reviewed changes
@MohammedAlghazali MohammedAlghazali dismissed stale reviews from rehabas and AlaaSaadeddin via bfe6507 April 3, 2020 14:09
rehabas
rehabas previously approved these changes Apr 3, 2020
View reviewed changes
AlaaSaadeddin
AlaaSaadeddin previously approved these changes Apr 3, 2020
View reviewed changes
Mu7ammadAbed
Mu7ammadAbed previously approved these changes Apr 3, 2020
View reviewed changes
@rehabas rehabas self-requested a review April 3, 2020 19:34
rehabas
rehabas previously approved these changes Apr 3, 2020
View reviewed changes
AlaaSaadeddin
AlaaSaadeddin previously approved these changes Apr 3, 2020
View reviewed changes
@MohammedAlghazali MohammedAlghazali dismissed stale reviews from AlaaSaadeddin and rehabas via 1dde4cf April 4, 2020 10:52
@Mu7ammadAbed Mu7ammadAbed merged commit 2bae3fc into master Apr 4, 2020
@Mu7ammadAbed Mu7ammadAbed deleted the 27-get-alumni branch April 4, 2020 17:55
@ranasobeid95 ranasobeid95 added Done and removed Awaiting Review This PR is ready and waiting for review labels Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranasobeid95 ranasobeid95 ranasobeid95 approved these changes

@Mu7ammadAbed Mu7ammadAbed Mu7ammadAbed approved these changes

@AlaaSaadeddin AlaaSaadeddin AlaaSaadeddin approved these changes

@MohammedYehia MohammedYehia MohammedYehia approved these changes

@rehabas rehabas Awaiting requested review from rehabas

Assignees

@MohammedAlghazali MohammedAlghazali

Labels
Backend Done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MohammedAlghazali @MohammedYehia @AlaaSaadeddin @Mu7ammadAbed @ranasobeid95 @rehabas