-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
govuk-react vs govuk-react-jsx #49
Comments
Having some hassle with server side rendering on govuk-react when it tries to import an image. Looking at why it works with custom components / volto core fine, but not gouk-react. |
surevine/govuk-react-jsx#107 seems related |
The 'packaging' used by We worked around this by using Eventually it might be worth trying to tweak how govuk-react-jsx is packaged to avoid this. |
Below is a summary of the key reasons we decided to move away from the
|
This is now merged to |
We ought to be able to drop this if govuk-react-jsx move away from UMD packaging |
@nosnickid can you raise this upstream, if you haven't already? |
The packaging side of things always makes my head explode 😆 Help me help you - what is it you're looking for? Can you raise an issue on the govuk-react-jsx backlog setting out what problems you're having and how you would like me to fix it? Thanks! |
Yeah JS packaging is an 'interesting' area. I'll undo the workaround we used locally and see what I can put together. |
Thanks. I've opened surevine/govuk-react-jsx#148 to look at this. If you could stick any thoughts or findings you have in there that would be great. |
govuk-react/govuk-react
is a work in progress module, that uses styled components to recreate the govuk design system.surevine/govuk-react-jsx
is more mature, and seems like a better way to use the design system.The text was updated successfully, but these errors were encountered: