Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocked mechanics counted as "fail" #295

Open
merforga opened this issue May 9, 2018 · 1 comment
Open

Blocked mechanics counted as "fail" #295

merforga opened this issue May 9, 2018 · 1 comment
Assignees

Comments

@merforga
Copy link
Member

merforga commented May 9, 2018

Currently, if a mechanic like Gorseval slam is blocked, it still counts as being hit in our boss metrics table. We need to filter out events where mechanics are blocked as well similar to how invulnerabled mechanics are filtered out currently.

@tomhalstead
Copy link
Collaborator

spectral_impact_events = events[(events.skillid == Skills.SPECTRAL_IMPACT) & events.dst_instid.isin(players.index) & (events.value > 0)]

The end of this line (events.value > 0) should filter out hits which don't actually deal damage, and other boss mechanics have this check where applicable. I reviewed the footage for several of my static's gorse attempts and my manual counts for hits/evades/blocks/invulns agree with our reported slams. This does mean that they are still counted if mitigated by stability, since the damage does get dealt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants