Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update DEV.md node version #1886

Merged
merged 4 commits into from
Oct 27, 2022

Conversation

joshr4
Copy link
Contributor

@joshr4 joshr4 commented Oct 26, 2022

#1735 Updated package.json to require node 18, resulting in an out of date version in the dev readme. This PR bumps the dev readme version to 18.12.0.

I'm using asdf locally to manage project specific node versions, it added a .tool-version file to track this. Hope thats ok to add also. https://asdf-vm.com/guide/getting-started.html#local

@joshr4 joshr4 changed the title add asdf .tool-versions file docs: update DEV.md node version Oct 27, 2022
@bodymindarts
Copy link
Member

Thank you for your contribution. In generally we don't want to enforce a specific local toolchain like nvm or asdf and we cannot support them all either. If you want to use .tool-version I recommend you add it to your global .gitignore so that it doesn't interfere with repos.

If we did decide to support something to manage the local dev setup it would probably be something deterministic like nix.

@bodymindarts bodymindarts merged commit 479cc34 into GaloyMoney:main Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants