Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON roundtrip test fails with carray backend on Erlang 20 #18

Open
kocolosk opened this issue May 31, 2018 · 1 comment
Open

JSON roundtrip test fails with carray backend on Erlang 20 #18

kocolosk opened this issue May 31, 2018 · 1 comment

Comments

@kocolosk
Copy link

I get the following error consistently on 20.1 and 20.3; the test succeeds for me on 19.3:

hyper_test:24: hyper_test_...*failed*
in function hyper_test:'-backend_t/0-fun-9-'/1 (test/hyper_test.erl, line 132)
in call from hyper_test:backend_t/0 (test/hyper_test.erl, line 132)
**error:{assertEqual,
    [{module,hyper_test},
     {line,132},
     {expression,
         "hyper : from_json ( hyper : to_json ( Carray ) , hyper_carray )"},
     {expected,{hyper,9,{hyper_carray,#Ref<0.3017655732.2247491585.178337>}}},
     {value,{hyper,9,{hyper_carray,#Ref<0.3017655732.2247491585.178346>}}}]}
  output:<<"">>

Not sure if that's a real issue or if there simply needs to be a different equivalence test on the roundtrip.

@kocolosk
Copy link
Author

After skimming through some of the carray code I don't see any reason why we'd expect the internal reference to be the same on a roundtrip. I also don't see any other equivalence test beyond serializing the registers again ... so maybe this particular test should just be disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant