Skip to content

Commit

Permalink
Remove package name from AndroidManfiest.xml to support AGP 8
Browse files Browse the repository at this point in the history
Remove the `package` manifest key to support AGP 8+

This means the library will now only support AGP 7+
  • Loading branch information
levibuzolic committed Apr 4, 2024
1 parent 7ace9e7 commit 385db0b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 7 deletions.
6 changes: 1 addition & 5 deletions android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,10 @@ def safeExtGet(prop, fallback) {
apply plugin: 'com.android.library'

android {
namespace 'com.gantix.JailMonkey'
compileSdkVersion safeExtGet('compileSdkVersion', 31)
buildToolsVersion safeExtGet('buildToolsVersion', "31.0.0")

def agpVersion = com.android.Version.ANDROID_GRADLE_PLUGIN_VERSION.tokenize('.')[0].toInteger()
if (agpVersion >= 7) {
namespace 'com.gantix.JailMonkey'
}

defaultConfig {
minSdkVersion safeExtGet('minSdkVersion', 21)
targetSdkVersion safeExtGet('targetSdkVersion', 31)
Expand Down
3 changes: 1 addition & 2 deletions android/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.gantix.JailMonkey">
<manifest xmlns:android="http://schemas.android.com/apk/res/android">
</manifest>

0 comments on commit 385db0b

Please sign in to comment.