Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation #656

Open
14 of 62 tasks
carstingaxion opened this issue May 4, 2024 · 9 comments
Open
14 of 62 tasks

Update documentation #656

carstingaxion opened this issue May 4, 2024 · 9 comments
Labels
documentation Improvements or additions to documentation Tracking Overview topic

Comments

@carstingaxion
Copy link
Collaborator

carstingaxion commented May 4, 2024

Is your enhancement related to a problem? Please describe.

I’d like to enhance the existing documentation. The current README.md houses one part of dev docs, that is going to be moved into the /docs/developer folder with #653

It might help contributors and extenders as well to have some additional docs about:

docs/developer/

Understanding GatherPress

Extending GatherPress

docs/contributor/

docs/user/

Designs

For now, I recommend, creating static markdown files until a new Playground-powered documentation workflow #765 is ready. A structure with named folders and just one README.md file per directory seems to be the most common way to do that.

The written docs should be accompanied by an auto-generated code reference.

Staying with GatherPress‘ close-to-core philosophy, I’d like to re-use existing stuff and get the benefit of a well-known UI on top. A working PoC for a GatherPress code reference using the same theme as developer.wordpress.org, can be found here carstingaxion/gatherpress-devhub#1 (comment)

Describe alternatives you've considered

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@carstingaxion carstingaxion added the enhancement New feature or request label May 4, 2024
@carstingaxion carstingaxion added the documentation Improvements or additions to documentation label Jun 4, 2024
@carstingaxion carstingaxion changed the title Update developer documentation Update documentation Aug 17, 2024
@carstingaxion
Copy link
Collaborator Author

He @shawfactor, what have you been searching for recently (in the context of GatherPress)? What needs to be in the dev-docs from your extenders-point-of-view? I would really appreciate your feedback over here!

@carstingaxion
Copy link
Collaborator Author

May I invite you too @oscarhugopaz, as you seem to do more development work, than a typical user, would you please add your thoughts here?!

What needs to be part of GatherPress developer documentation?

@shawfactor
Copy link

I’ve never looked at the documentation but I managed to understand the code. My only only bugbear was that many methods are protected which are useful for building templates and other plugin extensions. I’ve raised an issue for this already though as there are no security reasons why these methods are not accessible to everyone

@carstingaxion
Copy link
Collaborator Author

carstingaxion commented Aug 21, 2024

I’ve never looked at the documentation but I managed to understand the code.

Thanks @shawfactor, in the name of all who wrote that understandable code!

I felt & feel the same, that’s why I really enjoy contributing to that project! The existing code base is understandable and makes a lot of sense.

Maybe we could keep your statement for a later, as a first testimonial. Accompanying your great review on w.org ;)

My only only bugbear was that many methods are protected which are useful for building templates and other plugin extensions. I’ve raised an issue for this already though as there are no security reasons why these methods are not accessible to everyone

We talked about your issue #635 in last weeks huddle and concluded that the current implementation is based more on a general design decision, rather than being planned for extension. But we agree and are willing to change some of the methods.

Be absolutely invited to open PRs for all changes you see a need for!

@carstingaxion carstingaxion added Tracking Overview topic and removed enhancement New feature or request labels Aug 21, 2024
@shawfactor
Copy link

shawfactor commented Aug 25, 2024 via email

@carstingaxion
Copy link
Collaborator Author

The index of docs/contributor could become also the Contribution Guidelines GitHub wants us to add.

image

@carstingaxion carstingaxion moved this to In Progress in GatherPress Project Sep 19, 2024
@MervinHernandez
Copy link
Collaborator

QUEUE for Discussion - October 25

  • Mervin - strongly suggests breaking up this documentation ticket into smaller tickets for delegating / better tracking.
    -- Split 1 - section "x" of documentation
    -- Split 2 - connecting our dev docs to git required "Contributor Guidelines"
  • ?? Should this be split into a ticket for (more) changing of protected methods?

@MervinHernandez
Copy link
Collaborator

Queued to break this apart.

1 similar comment
@MervinHernandez
Copy link
Collaborator

Queued to break this apart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Tracking Overview topic
Projects
Status: In Progress
Development

No branches or pull requests

3 participants