-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation #656
Comments
He @shawfactor, what have you been searching for recently (in the context of GatherPress)? What needs to be in the dev-docs from your extenders-point-of-view? I would really appreciate your feedback over here! |
May I invite you too @oscarhugopaz, as you seem to do more development work, than a typical user, would you please add your thoughts here?! What needs to be part of GatherPress developer documentation? |
I’ve never looked at the documentation but I managed to understand the code. My only only bugbear was that many methods are protected which are useful for building templates and other plugin extensions. I’ve raised an issue for this already though as there are no security reasons why these methods are not accessible to everyone |
Thanks @shawfactor, in the name of all who wrote that understandable code! I felt & feel the same, that’s why I really enjoy contributing to that project! The existing code base is understandable and makes a lot of sense. Maybe we could keep your statement for a later, as a first testimonial. Accompanying your great review on w.org ;)
We talked about your issue #635 in last weeks huddle and concluded that the current implementation is based more on a general design decision, rather than being planned for extension. But we agree and are willing to change some of the methods. Be absolutely invited to open PRs for all changes you see a need for! |
Completely agree with you.
I swapped my sites over from another events calendar as gatgerpress does
things in a true open source way, seems open to suggestions, and plans to
work with existing Wordpress plugins
Happy for you to use my words as a testimonial
I believe having accessible methods or some alternatives like template
functions is essential though. Buddypress, bbpress, woocommerce etc don’t
try to do everything. Instead they benefit from an ecosystem that has grown
with them. In order to achieve this, accessing event characteristics like
times and descriptions in a flexible way (without having to reinvent the
wheel) is essential.
Pere
…On Wed, 21 Aug 2024 at 10:32 PM, Carsten Bach ***@***.***> wrote:
I’ve never looked at the documentation but I managed to understand the
code.
Thanks @shawfactor <https://github.com/shawfactor>, in the name of all
who wrote that understandable code!
I felt & feel the same, that’s why I really enjoy contributing to that
project! The existing code base is understandable and makes a lot of sense.
Maybe we could keep your statement for a later, as a first testimonial.
Accompanying your great review on w.org ;)
My only only bugbear was that many methods are protected which are useful
for building templates and other plugin extensions. I’ve raised an issue
for this already though as there are no security reasons why these methods
are not accessible to everyone
We talked about your issue #635
<#635> in last weeks
huddle and concluded that the current implementation is based more on a
general design decision, rather than being planned for extension. But we
agree and are willing to change some of the methods.
Be absolutely invited to open PRs for all changes you see a need for!
—
Reply to this email directly, view it on GitHub
<#656 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAE55YPC2M7GILHUC7AA3STZSSCE7AVCNFSM6AAAAABHHFNRYCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBRHE2DANBUHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
QUEUE for Discussion - October 25
|
Queued to break this apart. |
1 similar comment
Queued to break this apart. |
Is your enhancement related to a problem? Please describe.
I’d like to enhance the existing documentation.
The current✅README.md
houses one part of dev docs, that is going to be moved into the/docs/developer
folder with #653It might help contributors and extenders as well to have some additional docs about:
docs/developer/
Understanding GatherPress
wpcli
commands that GatherPress providesExtending GatherPress
theme.json
docs/contributor/
wp-env
development environment (existing)docs/user/
Designs
For now, I recommend, creating static markdown files until a new Playground-powered documentation workflow #765 is ready. A structure with named folders and just one README.md file per directory seems to be the most common way to do that.
The written docs should be accompanied by an auto-generated code reference.
Staying with GatherPress‘ close-to-core philosophy, I’d like to re-use existing stuff and get the benefit of a well-known UI on top. A working PoC for a GatherPress code reference using the same theme as
developer.wordpress.org
, can be found here carstingaxion/gatherpress-devhub#1 (comment)Describe alternatives you've considered
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: