Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looooong timezone-array needed everywhere? #923

Open
1 task done
carstingaxion opened this issue Sep 26, 2024 · 0 comments
Open
1 task done

Looooong timezone-array needed everywhere? #923

carstingaxion opened this issue Sep 26, 2024 · 0 comments
Labels
bug Something isn't working question Further information is requested
Milestone

Comments

@carstingaxion
Copy link
Collaborator

carstingaxion commented Sep 26, 2024

Describe your question

Does GatherPress really need all possible timezones:

  • in the frontend markup?
  • in the backend markup?
  • on every page load?

https://github.com/carstingaxion/gatherpress/blob/02358ab60318a7464e31865ffea0f3bb8c961809/includes/core/classes/class-assets.php#L306

@swissspidy: Aside: just adding a script tag like this is usually not a good idea. You should at least use wp_print_inline_script_tag. Even better, attach it to a specific script with wp_add_inline_script.

@carstingaxion: I wanted to suggest the same, even that the relevant data - the timezones, in this case - are only used for the Event Date Block (#684)

Code of Conduct

  • I agree to follow this project's Code of Conduct
@carstingaxion carstingaxion added question Further information is requested bug Something isn't working labels Sep 26, 2024
@carstingaxion carstingaxion added this to the 0.32.0 milestone Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant