Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cached/database entry of mod ID could show duplicate entry until rediscovery if mod id changes #196

Open
XDelta opened this issue Jul 13, 2024 · 1 comment

Comments

@XDelta
Copy link

XDelta commented Jul 13, 2024

Mod id changes are rare and shouldn't happen often but they can occur, most often if someone changes domain and updates their mod reverse tld to match

Having 1.1.1 installed and just removed (after the manifest got updated, but without rediscovery)
Resolute_2024-07-13_08-42-24

Restarting Resolute and Rediscovering mods (after adding 1.1.1 again for it to discover)
Resolute_2024-07-13_08-47-54

Partly related to #128

@Gawdl3y
Copy link
Owner

Gawdl3y commented Jul 13, 2024

I don't think there's much to be done about this one, since the ID is the definitive way that Resolute currently identifies a mod. If a mod's ID changes, it'd be expected for there to be temporary duplicates depending on the situation. In order to deduplicate these, there'd have to be some kind of heuristics to match two similar mods together - whether that be just seeing if all of their artifacts names and/or hashes match, or just the mod name as well, etc. I'm not a huge fan of that conceptually, however, because it seems like it'd be somewhat fragile and could potentially cause issues in the future for legitimate "duplicates".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants