Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign core #500

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

Redesign core #500

wants to merge 26 commits into from

Conversation

skim0119
Copy link
Collaborator

@skim0119 skim0119 commented Nov 27, 2024

Description

Some major refactoring to accommodate for Python 3.10+.

Fixes #501, fixes #309,

Features

  • Pipeline can take multiple Operators.
  • Rework on cores: ducktyping relation redone for cleaner hinting the behavior.
  • Adding callback function can be done without having self parameter in free-function.
  • Callback takes care the plotting together, and plotting can only be launched from
  • Callbacks only launch once, and must be reset to run again.
  • Clear separation between operation chain representation vs pipeline.
  • Cache-check is done by exception handling instead.
  • Remove unnecessary protocol behaviors.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • make test

@skim0119 skim0119 marked this pull request as ready for review December 1, 2024 07:40
@skim0119 skim0119 self-assigned this Dec 1, 2024
@skim0119 skim0119 added bug Something isn't working enhancement New feature or request labels Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to bump neo and elephant version [Bug] Upstream cache miss does not propagate downstream
1 participant